Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Clarify Pickers Component composition section #12097

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 16, 2024

Fixes #9038

Update the Component composition section on all Pickers pages.

Avoid the emphasis on the fact that all props of the composed components are available on the Picker (they are not).
Instead of it, I added a section clarifying the props situation after the list of documentation pages for composed components.

@LukasTy LukasTy added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Feb 16, 2024
@LukasTy LukasTy self-assigned this Feb 16, 2024
@LukasTy LukasTy added the needs cherry-pick The PR should be cherry-picked to master after merge label Feb 20, 2024
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement 👌

docs/.link-check-errors.txt Outdated Show resolved Hide resolved
@LukasTy LukasTy enabled auto-merge (squash) February 20, 2024 09:01
@LukasTy LukasTy merged commit e9ebe64 into mui:next Feb 20, 2024
15 checks passed
@LukasTy LukasTy deleted the clarify-component-composition-doc branch February 20, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Variant not passed to DateField
4 participants