[core] Fix docs link check #12135
Merged
[core] Fix docs link check #12135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
requested review from
flaviendelangle,
michelengelen and
alexfauquette
LukasTy
commented
Feb 19, 2024
Comment on lines
-6
to
-7
| - https://mui.com/material-ui/api/input-base/#InputBase-prop-disableInjectingGlobalStyles | ||
| - https://mui.com/material-ui/api/menu-item/#css |
There was a problem hiding this comment.
These are fixed in mui/material-ui#41185
|
Deploy preview: https://deploy-preview-12135--material-ui-x.netlify.app/ Updated pages: |
LukasTy
added
the
needs cherry-pick
LukasTy
added a commit
to LukasTy/mui-x
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while working on #12097.
Noticed that adding a link to the API page with a hash (i.e.
/x/api/date-field/#props) adds it to the list of broken links when we try to ignore errors from generated paths (at least hashes) of generated API paths.Looked into the issue and it seems that our check was incorrect and we were adding all links to hashed API pages to the error list... 🙈
There were a few legitimately broken links, fixed those.
There was a missing check (which exists on the Core repo) for dynamically generated base
hooks-apiorcomponents-apipaths as well. 🙈