Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all components] Remove legacy IE 11 bundle #12151

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

flaviendelangle
Copy link
Member

Part of #12141

Weird to flag it as "core" since it impacts the user...
Not sure how we should talk about it (cc @oliviertassinari )

@flaviendelangle flaviendelangle self-assigned this Feb 20, 2024
@flaviendelangle flaviendelangle added the core Infrastructure work going on behind the scenes label Feb 20, 2024
@mui-bot
Copy link

mui-bot commented Feb 20, 2024

Deploy preview: https://deploy-preview-12151--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 9e64dab

@oliviertassinari oliviertassinari changed the title [core] Remove legacy bundle [core] Remove legacy IE 11 bundle Feb 20, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 20, 2024

Weird to flag it as "core" since it impacts the user

[data grid][charts][tree view]… this will be long, maybe something like [all components].

@flaviendelangle flaviendelangle changed the title [core] Remove legacy IE 11 bundle [all components] Remove legacy IE 11 bundle Feb 20, 2024
@flaviendelangle
Copy link
Member Author

[data grid][charts][tree view]… this will be long

And not scalable 😆

@oliviertassinari
Copy link
Member

According to CodeSandbox CI, the Data Grid npm package goes from 5.5 MB to 4.4 MB, cool, probably doesn't matter, but 😁

@flaviendelangle flaviendelangle merged commit 4ad004d into mui:next Feb 21, 2024
18 checks passed
@flaviendelangle flaviendelangle deleted the legacy-bundle branch February 21, 2024 09:47
@flaviendelangle
Copy link
Member Author

According to CodeSandbox CI, the Data Grid npm package goes from 5.5 MB to 4.4 MB

IMHO the main benefit is to save a few seconds before our Codesandbox are ready in the PRs 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants