Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Make column resizing and autosizing available in Community plan #12420

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

cherniavskii
Copy link
Member

Closes #12358

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! feature: Column resize labels Mar 11, 2024
@mui-bot
Copy link

mui-bot commented Mar 11, 2024

@cherniavskii cherniavskii marked this pull request as ready for review March 12, 2024 14:13
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, MIT community is empowered more now 💪 🎉
One of the prominent highlights of the release this week + stable release announcements!
Nit: Might want to update here after the PR merge.

@@ -436,7 +440,11 @@ export const useGridColumnResize = (
fillerLeftRef.current = findGridElement(apiRef.current, 'filler--pinnedLeft');
fillerRightRef.current = findGridElement(apiRef.current, 'filler--pinnedRight');

const pinnedPosition = apiRef.current.isColumnPinned(colDef.field);
const pinnedPosition = apiRef.current.unstable_applyPipeProcessors(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/data/data-grid/column-dimensions/ColumnAutosizing.js Outdated Show resolved Hide resolved
@cherniavskii cherniavskii enabled auto-merge (squash) March 12, 2024 15:29
@cherniavskii cherniavskii merged commit b721c3d into mui:next Mar 12, 2024
15 checks passed
@cherniavskii cherniavskii deleted the column-resizing-community-plan branch March 12, 2024 16:15
@Janpot
Copy link
Member

Janpot commented May 10, 2024

Oh wow, how did I miss this? This is huge, column resizing was literally the only reason why I wasn't using X grid in side projects. Great initiative 🚀

resizable={false}
resizable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong to me. Issue open: #13247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Column resize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Move column resizing and autosizing features to the community plan
5 participants