[docs] Fix some typos in charts docs #13906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com>
Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com>
Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com>
Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com>
oliviertassinari
added
component: charts
|
I'm confused by the API. Why do we map <LineChart
xAxis={[{ data: sample }]}
yAxis={[
{ id: 'linearAxis', scaleType: 'linear' },
{ id: 'logAxis', scaleType: 'log' },
]}
series={[
{ yAxisKey: 'linearAxis', data: sample, label: 'linear' },
{ yAxisKey: 'logAxis', data: sample, label: 'log' },
]}
leftAxis="linearAxis"
rightAxis="logAxis"
height={400}
/>https://deploy-preview-13906--material-ui-x.netlify.app/x/react-charts/axis/#defining-axis Why not: <LineChart
xAxis={[{ data: sample }]}
yAxis={[
{ id: 'linearAxis', scaleType: 'linear' },
{ id: 'logAxis', scaleType: 'log' },
]}
series={[
{ yAxisId: 'linearAxis', data: sample, label: 'linear' },
{ yAxisId: 'logAxis', data: sample, label: 'log' },
]}
leftAxisId="linearAxis"
rightAxisId="logAxis"
height={400}
/>or <LineChart
xAxis={[{ data: sample }]}
yAxis={[
{ id: 'linearAxis', scaleType: 'linear' },
{ id: 'logAxis', scaleType: 'log' },
]}
series={[
{ yAxis: 'linearAxis', data: sample, label: 'linear' },
{ yAxis: 'logAxis', data: sample, label: 'log' },
]}
leftAxis="linearAxis"
rightAxis="logAxis"
height={400}
/> |
arminmeh
previously requested changes
Jul 22, 2024
Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com>
7 tasks
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
JCQuintas
approved these changes
Jul 24, 2024
JCQuintas
dismissed
arminmeh’s stale review
Request was fulfilled, dismissing so I can merge this.
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Christina <156356273+cratiu222@users.noreply.github.com> Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Jose C Quintas Jr <juniorquintas@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I found some minor typos issues in your docs.
Br, Christina.