[DataGrid] Add dark mode scrollbar #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I have proposed an improved version, it handles:
- Add support for Firefox
- Add support for the corner color:
- Improve the contrast radio: https://webaim.org/resources/contrastchecker/?fcolor=404040&bcolor=191919.
- Add a min size for the thumb, as the default version has (otherwise it might be too small to be noticed)
- Add an "active" color when dragging with even more contrast.
Before
After
packages/grid/x-grid-modules/src/components/styled-wrappers/GridRootStyles.ts
Outdated
Show resolved
Hide resolved
packages/grid/x-grid-modules/src/components/styled-wrappers/GridRootStyles.ts
Outdated
Show resolved
Hide resolved
|
I'm testing on Windows now. |
All good on Windows. For those who wonder, the solution is coming from StackOverflow, not a question, from their source 😄.
|
|
Let's discuss this in a separate issue so that we don't make this PR too noisy. |
1 task
|
Sure, done: mui/material-ui#22594 |
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari
approved these changes
Sep 14, 2020
oliviertassinari
added
the
component: data grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260