Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Dark mode scrollbar #260

Closed
2 tasks done
oliviertassinari opened this issue Sep 10, 2020 · 0 comments · Fixed by #282
Closed
2 tasks done

[DataGrid] Dark mode scrollbar #260

oliviertassinari opened this issue Sep 10, 2020 · 0 comments · Fixed by #282
Assignees
@dtassone
Labels
component: data grid This is the name of the generic UI component, not the React module!

Comments

@oliviertassinari
Copy link
Member

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

image

Expected Behavior 🤔

No white area

Steps to Reproduce 🕹

  1. Open https://master--material-ui-x.netlify.app/components/data-grid/#commercial-version
  2. Turn dark mode

Context 🔦

Most traders display the grid on a dark background, take https://openfin.co/ or https://perspective.finos.org/ as an example.

Your Environment 🌎

Tech Version
Material-UI X v0.1.67
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Sep 10, 2020
@oliviertassinari oliviertassinari mentioned this issue Sep 11, 2020
Merged
dtassone added a commit to dtassone/material-ui-x that referenced this issue Sep 14, 2020
@dtassone
fix mui#260 styling scrollbar for dark mode
06a0640
@oliviertassinari oliviertassinari mentioned this issue Sep 14, 2020
Merged
dtassone added a commit that referenced this issue Sep 14, 2020
@dtassone @oliviertassinari
[DataGrid] Add dark mode scrollbar (#282)
f079f61 
* styling scroll bar

* fix #260 styling scrollbar for dark mode

* small refactoring

* Apply suggestions from code review

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* fix prettier

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtassone dtassone

Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Add dark mode scrollbar dtassone/material-ui-x
2 participants
@dtassone @oliviertassinari