-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] update l10n issue with a single command line #3588
Conversation
Do you plan to create the GitHub workflow? It would be nice to have this automated. |
I'm not planning to do it for now, because I do not know exactly how files are managed in github workflow. Which could be a problem, especially with the following part of the code. function git(args: any) {
return new Promise((resolve, reject) => {
exec(`git ${args}`, (err, stdout) => {
if (err) {
reject(err);
} else {
resolve(stdout.trim());
}
});
});
} I agree it would be better, but for now, updating the issue at least once a week during the release seems enought |
scripts/README.md
Outdated
@@ -63,6 +63,16 @@ You can use the following script in your browser console on any GitHub page to a | |||
4. Release the versions on NPM: `yarn release:publish` (you need your 2FA device). | |||
5. Create a new tag named with the release you just did `git tag v4.0.0-alpha.30 && git push upstream --tag` | |||
|
|||
### Update l10n issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this section. I'll open another PR to add the GitHub workflow to always keep this issue up-to-date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I let it, and you will remove it in the PR to add the GitHub workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can keep it. Once we have this running automatically I don't think it's necessary to mention it in the README, it's one thing less to care about.
It works in the same way as in your machine. We first https://github.com/mui-org/material-ui/blob/master/.github/workflows/ci.yml#L22 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
These are the results for the performance tests:
|
@m4theushw I made the script to make the update when there is a push on master. If you can verify it. I don't know how to test it except merging and hope it works |
.github/workflows/l10n.yml
Outdated
@@ -0,0 +1,29 @@ | |||
name: CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: CI | |
name: Update missing translations |
.github/workflows/l10n.yml
Outdated
# Don't need playwright in this job | ||
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
- name: yarn release:tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: yarn release:tag | |
- name: yarn l10n --report |
- name: yarn release:tag | ||
run: | | ||
git remote -v | ||
yarn l10n --report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GITHUB_TOKEN
envvar is missing.
It's a shot in the dark, we test after merge. You could configure GitHub Actions in your fork. It might not work initially but we can fix. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
No description provided.