Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix sorting feature link #3877

Merged
merged 2 commits into from Feb 10, 2022
Merged

[docs] Fix sorting feature link #3877

merged 2 commits into from Feb 10, 2022

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Feb 7, 2022 •
edited by oliviertassinari

flaviendelangle
flaviendelangle reviewed Feb 7, 2022
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoudn't we do like for filtering ?
With a "Sorting" section of two lines

  • Column sorting
  • Multi-column sorting

@mui-bot
Copy link

mui-bot commented Feb 7, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 203.6 370.5 251.3 279 59.556
Sort 100k rows ms 356.2 609.1 589.8 546.26 95.583
Select 100k rows ms 139.2 208.2 143.1 159.68 26.556
Deselect 100k rows ms 96.8 284.4 187.7 169.62 68.482

Generated by 🚫 dangerJS against b7807bf

@alexfauquette
Copy link
Member Author

alexfauquette commented Feb 7, 2022 •
edited

I like the idea :)
I will do the change in core repo

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Feb 7, 2022
@siriwatknp
Copy link
Member

👋 The migration PR has been merged.

Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)

  1. pull latest master from upstream to your branch
  2. if your PR has changes on the *.md or demo files, you are likely to encounter conflict because all of them have been moved to the new folder.
    2.1 revert the change on those markdown files you did
    2.2 pull latest master from upstream (you should not see conflict)
    2.3 make the changes again at docs/data/material/*
  3. run yarn docs:api
    • you might see the changes in docs/pages/material/api/* if your PR touches some of the components
    • it is okay if there is no changes

If you are struggle with the steps above, feel free to tag @siriwatknp

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 8, 2022
@alexfauquette alexfauquette self-assigned this Feb 9, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 9, 2022
@alexfauquette alexfauquette merged commit d749214 into mui:master Feb 10, 2022
@alexfauquette alexfauquette deleted the fix-doc-links branch February 10, 2022 10:57
@oliviertassinari oliviertassinari mentioned this pull request Feb 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees

@alexfauquette alexfauquette

Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexfauquette @mui-bot @siriwatknp @oliviertassinari @flaviendelangle