-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Sync MUI X table feature #30913
Conversation
I have noticed that we have an issues with our anchor links. One example sorting: and They point to https://mui.com/components/data-grid/rows/#row-sorting ❌ |
I'm fixing it. Do we have some tools to detect broken links? |
@alexfauquette Great, mind that others might be broken too in this table.
I recall we chatted a bit about this problem with @flaviendelangle on a similar instance of a regression. Unfortunately, no, we have no tools to detect broken anchor links. We have ahrefs that crawl all the pages every Friday, but it only reports SEO issues, 301, 404, nothing on anchor links. Maybe such a tool exists 🤔. At least, working on reducing the vertical scrollbar of the pages reduces the scale of this problem. |
38b462b
to
5164efa
Compare
@oliviertassinari Effectively, some other links to x-team doc were broken. Now, that's corrected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I killed the getUrl
so we can grep in the codebase full URLs (I think more important than being DRY) and fixed one last broken anchor.
@alexfauquette Great, thanks! |
Add "master detail" and "row grouping" as developed on the pricing page
https://deploy-preview-30913--material-ui.netlify.app/pricing/
It's the same as mui/mui-x#3877 but since we duplicate the content, we have to update both locations.