Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Sync MUI X table feature #30913

Merged
merged 5 commits into from
Feb 19, 2022

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Feb 4, 2022

Add "master detail" and "row grouping" as developed on the pricing page

https://deploy-preview-30913--material-ui.netlify.app/pricing/

It's the same as mui/mui-x#3877 but since we duplicate the content, we have to update both locations.

@mui-bot
Copy link

mui-bot commented Feb 4, 2022

No bundle size changes

Generated by 🚫 dangerJS against 2afdc3e

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Feb 4, 2022
@oliviertassinari oliviertassinari changed the title [docs] update MUI-X features [website] Sync MUI X table feature Feb 5, 2022
@oliviertassinari oliviertassinari added website Pages that are not documentation-related, marketing-focused. and removed docs Improvements or additions to the documentation labels Feb 5, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 5, 2022

I have noticed that we have an issues with our anchor links. One example sorting:

Screenshot 2022-02-05 at 13 04 52

and

Screenshot 2022-02-05 at 13 05 37

They point to https://mui.com/components/data-grid/rows/#row-sorting

@alexfauquette
Copy link
Member Author

I'm fixing it. Do we have some tools to detect broken links?

@oliviertassinari
Copy link
Member

I'm fixing it.

@alexfauquette Great, mind that others might be broken too in this table.

Do we have some tools to detect broken links?

I recall we chatted a bit about this problem with @flaviendelangle on a similar instance of a regression. Unfortunately, no, we have no tools to detect broken anchor links. We have ahrefs that crawl all the pages every Friday, but it only reports SEO issues, 301, 404, nothing on anchor links. Maybe such a tool exists 🤔. At least, working on reducing the vertical scrollbar of the pages reduces the scale of this problem.

@alexfauquette
Copy link
Member Author

mind that others might be broken too in this table.

@oliviertassinari Effectively, some other links to x-team doc were broken. Now, that's corrected

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I killed the getUrl so we can grep in the codebase full URLs (I think more important than being DRY) and fixed one last broken anchor.

@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Feb 15, 2022
@oliviertassinari oliviertassinari merged commit 7c0a320 into mui:master Feb 19, 2022
@oliviertassinari
Copy link
Member

@alexfauquette Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants