Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license generating script #4055

Merged
merged 3 commits into from
Mar 1, 2022
Merged

Fix license generating script #4055

merged 3 commits into from
Mar 1, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Feb 28, 2022

  • The CommonJs build output seems to be at the root of the build folder now.
  • Updated CLI params aliases to comply with the error message "MUI: You forgot to pass an order number. $ > licensegen -o order_123."
    throw new Error('MUI: You forgot to pass an order number. $ > licensegen -o order_123.');

@mui-bot
Copy link

mui-bot commented Feb 28, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 249.8 550.1 355.8 357.3 109.48
Sort 100k rows ms 498.1 984.4 879.5 818.94 181.229
Select 100k rows ms 137.7 278.5 194.5 206.18 46.479
Deselect 100k rows ms 106.9 277.4 181.4 181.9 64.767

Generated by 🚫 dangerJS against 6388349

@flaviendelangle
Copy link
Member

@Janpot #3965 changes the path so we will have to test after merging them.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 1, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 1, 2022
@Janpot
Copy link
Member Author

Janpot commented Mar 1, 2022

@flaviendelangle #3965 fixed the import path, so all that remains now is the CLI alias

@Janpot Janpot merged commit dfbb9bd into mui:master Mar 1, 2022
@Janpot Janpot deleted the license-script branch March 1, 2022 09:31
@oliviertassinari oliviertassinari added the package: x-license Specific to @mui/x-license. label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: x-license Specific to @mui/x-license.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants