[data grid] Fix implicit dependency on react-dom #5121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
oliviertassinari
commented
Jun 5, 2022
| @@ -1,5 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import ReactDOM from 'react-dom'; | |||
| import * as ReactDOM from 'react-dom'; | |||
There was a problem hiding this comment.
A bonus refactoring, to match the docs: https://reactjs.org/docs/react-dom.html.
|
These are the results for the performance tests:
|
oliviertassinari
added
dependencies
m4theushw
approved these changes
Jun 6, 2022
joserodolfofreitas
pushed a commit
to joserodolfofreitas/mui-x
that referenced
this pull request
Jun 13, 2022
|
It worked, it's more accurate now, only 126.4 kB gzipped 😁
|
| @@ -1,5 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import ReactDOM from 'react-dom'; | |||
| import * as ReactDOM from 'react-dom'; | |||
There was a problem hiding this comment.
@m4theushw When do we plan to use React 18? It would then be
Suggested change
| import * as ReactDOM from 'react-dom'; | |
| import * as ReactDOM from 'react-dom/client'; |
per https://reactjs.org/blog/2022/03/29/react-v18.html#new-client-and-server-rendering-apis
There was a problem hiding this comment.
I'm only waiting for the core repo to adopt React 18 in the infra. But nothing stops us from adopting earlier. #4155 is open.
2 tasks
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was on mui/material-ui#33015 (comment), having a quick look at what could explain the jump in bundle size in the data grid at version v5.9.0. We went from 78.1 to 122.1 KB. Compared to react-table 15.7 KB it can be intimidating. I could identify the origin down to #4332, we depend on
react-dom:mui-x/packages/grid/x-data-grid/src/hooks/features/virtualization/useGridVirtualScroller.tsx
Line 2 in 23aaa6b
but we don't list the dependency.