Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Improve German (de-DE) locale #5448

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

sebastianfrey
Copy link
Contributor

Add missing translations for DataGrid.

@mui-bot
Copy link

mui-bot commented Jul 11, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 266.5 612.5 514.4 464.12 120.48
Sort 100k rows ms 517.3 1,126.7 517.3 853.94 226.806
Select 100k rows ms 121.5 237.6 201.2 189.32 42.437
Deselect 100k rows ms 109.4 265.6 200.6 186.86 64.632

Generated by 🚫 dangerJS against 34f25ca

@sebastianfrey
Copy link
Contributor Author

@alexfauquette any idea why the Argos-CI check might have failed?

@flaviendelangle flaviendelangle changed the title [DataGrid][l10n] Improve German (de-DE) locale [DataGrid] Improve German (de-DE) locale Jul 12, 2022
@m4theushw m4theushw added the l10n localization label Jul 12, 2022
@ximex
Copy link
Contributor

ximex commented Jul 13, 2022

fixes part of #3211

@joserodolfofreitas
Copy link
Member

Thanks again for your contributions, @sebastianfrey!

@sebastianfrey
Copy link
Contributor Author

@m4theushw I think this PR was closed accidentally?

@m4theushw
Copy link
Member

My bad. I didn't realize that using "Fixes (comment)" would also close this one.

@m4theushw m4theushw merged commit 9e69893 into mui:master Jul 14, 2022
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
@sebastianfrey sebastianfrey deleted the x-data-grid-de-locales branch July 24, 2022 18:36
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants