Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Wait for flags to load on regression tests #5473

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw added the test label Jul 12, 2022
@mui-bot
Copy link

mui-bot commented Jul 12, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 242.1 476.2 298.5 333.44 84.297
Sort 100k rows ms 471.9 803.6 626.8 658 118.412
Select 100k rows ms 133.7 225.6 171.5 169.34 33.76
Deselect 100k rows ms 99.9 180.3 178.3 143.32 31.275

Generated by 🚫 dangerJS against 3e0cd43

@m4theushw m4theushw merged commit b8c2b84 into mui:master Jul 13, 2022
@m4theushw m4theushw deleted the wait-for-flag branch July 13, 2022 22:35
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 6, 2022

In the project I worked on before MUI, we solved the problem like this:

  await page.evaluate(async () => {
    const selectors = Array.from(document.querySelectorAll('img'))
    await Promise.all(
      selectors.map(img => {
        // The image is already loaded      
        if (img.complete) {
          return null
        }

        return new Promise(resolve => {
          img.addEventListener('load', resolve)
          img.addEventListener('error', resolve)
        })
      })
    )
  })

Is this something that could work? It seems a challenge to keep pathsToNotWaitForFlagCDN in sync with the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants