Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Improve typing for styleOverrides #5818

Merged

Conversation

iigrik
Copy link
Contributor

@iigrik iigrik commented Aug 17, 2022

@mui-bot
Copy link

mui-bot commented Aug 17, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 311.5 644.8 386.3 422.94 118.137
Sort 100k rows ms 447.5 798 697.9 670.72 118.473
Select 100k rows ms 151 279.4 215.2 221.6 43.263
Deselect 100k rows ms 125.2 285.1 191.5 196.68 51.155

Generated by 🚫 dangerJS against 134e3ff

@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Aug 17, 2022
…issue/5816-support-datagrid-styleoverrides-ts
@iigrik
Copy link
Contributor Author

iigrik commented Aug 31, 2022

Hi @m4theushw. Could you check please this MR?

@DanailH DanailH changed the base branch from master to next September 12, 2022 09:39
@flaviendelangle
Copy link
Member

@DanailH it's a community PR, should we merge it ?

@m4theushw m4theushw added the needs cherry-pick The PR should be cherry-picked to master after merge label Nov 18, 2022
@m4theushw m4theushw merged commit c8f112c into mui:next Nov 18, 2022
m4theushw pushed a commit to m4theushw/mui-x that referenced this pull request Nov 23, 2022
@m4theushw m4theushw changed the title [DataGrid] Improve typing for styleOverrides [DataGrid] Improve typing for styleOverrides Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] styleOverrides does not support Theme typings
6 participants