-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Improve typing for styleOverrides
#5818
Merged
m4theushw
merged 7 commits into
mui:next
from
iigrik:issue/5816-support-datagrid-styleoverrides-ts
Nov 18, 2022
Merged
[DataGrid] Improve typing for styleOverrides
#5818
m4theushw
merged 7 commits into
mui:next
from
iigrik:issue/5816-support-datagrid-styleoverrides-ts
Nov 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the results for the performance tests:
|
oliviertassinari
added
the
component: data grid
This is the name of the generic UI component, not the React module!
label
Aug 17, 2022
…tation" This reverts commit e96edea.
…issue/5816-support-datagrid-styleoverrides-ts
Hi @m4theushw. Could you check please this MR? |
DanailH
approved these changes
Sep 12, 2022
@DanailH it's a community PR, should we merge it ? |
m4theushw
added
the
needs cherry-pick
The PR should be cherry-picked to master after merge
label
Nov 18, 2022
m4theushw
pushed a commit
to m4theushw/mui-x
that referenced
this pull request
Nov 23, 2022
m4theushw
changed the title
[DataGrid] Improve typing for styleOverrides
[DataGrid] Improve typing for Nov 23, 2022
styleOverrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: data grid
This is the name of the generic UI component, not the React module!
needs cherry-pick
The PR should be cherry-picked to master after merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5816
Before: https://codesandbox.io/s/datagridpro-styleoverrides-issue-0k8c4r
After: https://codesandbox.io/s/datagridpro-styleoverrides-issue-forked-2s6x1g?file=/src/App.tsx