Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Improve typing for theme in styleOverrides #6920

Merged
merged 1 commit into from
Nov 23, 2022
Merged

[DataGridPremium] Improve typing for theme in styleOverrides #6920

merged 1 commit into from
Nov 23, 2022

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Nov 19, 2022 •
edited

@m4theushw m4theushw added component: data grid This is the name of the generic UI component, not the React module! typescript labels Nov 19, 2022
@mui-bot
Copy link

mui-bot commented Nov 19, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6920--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 636.9 1,059.8 636.9 802.92 193.347
Sort 100k rows ms 615 1,190.3 615 939.88 201.547
Select 100k rows ms 209.7 375.4 306.4 289.04 63.723
Deselect 100k rows ms 145.3 368.3 211.4 223.96 76.508

Generated by 🚫 dangerJS against e5e2a27

LukasTy
LukasTy approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the premium data grid component has specific props available only on it—you could also consider adding a themeAugmentation.spec.ts to test those. 😉

@m4theushw m4theushw merged commit 7df3fe1 into mui:next Nov 23, 2022
@m4theushw m4theushw deleted the data-grid-premium-theme-augmentation branch November 23, 2022 22:35
m4theushw added a commit to m4theushw/mui-x that referenced this pull request Nov 23, 2022
@m4theushw
[DataGridPremium] Improve typing for theme in styleOverrides (mui#6920
e0ded9c 
)
@m4theushw m4theushw mentioned this pull request Nov 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@cherniavskii cherniavskii cherniavskii approved these changes

@DanailH DanailH Awaiting requested review from DanailH

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@m4theushw @mui-bot @LukasTy @cherniavskii