[DataGridPro] Fix filtering with inactive items #5993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
force-pushed
the
fix-filtering2
branch
from
4389448
to
c26c4c9
Compare
|
These are the results for the performance tests:
|
cherniavskii
approved these changes
Sep 1, 2022
| @@ -75,6 +75,53 @@ describe('<DataGridPro /> - Filter', () => { | |||
| expect(getColumnValues(0)).to.deep.equal(['Adidas', 'Puma']); | |||
| }); | |||
|
|
|||
| it('should not apply items that are incomplet with AND operator', () => { | |||
There was a problem hiding this comment.
Suggested change
| it('should not apply items that are incomplet with AND operator', () => { | |
| it('should not apply items that are incomplete with AND operator', () => { |
| expect(getColumnValues(0)).to.deep.equal(['Adidas', 'Puma']); | ||
| }); | ||
|
|
||
| it('should not apply items that are incomplet with OR operator', () => { |
There was a problem hiding this comment.
Suggested change
| it('should not apply items that are incomplet with OR operator', () => { | |
| it('should not apply items that are incomplete with OR operator', () => { |
| render( | ||
| <TestCase | ||
| filterModel={{ | ||
| items: [ |
There was a problem hiding this comment.
Suggested change
| items: [ | |
| linkOperator: GridLinkOperator.And, | |
| items: [ |
To not rely on default link operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5989