-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YearPicker] Scroll to the current year even with autoFocus=false
#6089
Conversation
These are the results for the performance tests:
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Unify RFC template using core version
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
autoFocus=true
autoFocus=false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to achieve the same behavior without adding a new div ?
And what do you think about hiding the content of the div before the scroll is completed ?
Because in it's current shape, we have an ugly flickering.
It was a bit more complicated, but yes I managed to do the same by customizing the existing div I do not see the flickering. (light mode the PR deploy, dark mode the current doc) year.scroll.mp4 |
Use |
c489323
to
7955193
Compare
For the blink, it's not a problem with the ref that is responsible. The autofocus has the same behavior Screencast.from.13.09.22.11.55.06.mp4You would like to add a About avoiding to add a new div, I realized I ended up using We have the following structure: <CalendarRoot> // a display flex column
<CalendarHeader /> // fix height
<TransitionGroup> // extends as much as possible (height: 100%)
<div>
<RenderedView/> The problem is that with I can not put the The current solution I implemented is to manage the scroll in the |
OK, it's not very sexy, but if the
Makes sense to me |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
autoFocus=false
autoFocus=false
Fix #4601