Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix memory leak on grid unmount #6620

Merged
merged 1 commit into from
Oct 24, 2022
Merged

[DataGrid] Fix memory leak on grid unmount #6620

merged 1 commit into from
Oct 24, 2022

Conversation

cherniavskii
Copy link
Member

Port of #6579 to next branch

@cherniavskii cherniavskii added performance component: data grid This is the name of the generic UI component, not the React module! regression A bug, but worse labels Oct 24, 2022
@cherniavskii cherniavskii mentioned this pull request Oct 24, 2022
Merged
1 task
@mui-bot
Copy link

mui-bot commented Oct 24, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6620--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 469.7 785.7 625 619.84 124.789
Sort 100k rows ms 507.2 976.9 714.1 737.14 153.498
Select 100k rows ms 193.8 290.6 214.7 225.2 34.426
Deselect 100k rows ms 127.8 202.3 186.1 168.16 29.517

Generated by 🚫 dangerJS against 20f002a

@cherniavskii cherniavskii marked this pull request as ready for review October 24, 2022 13:34
@cherniavskii cherniavskii merged commit 77daa1f into mui:next Oct 24, 2022
@cherniavskii cherniavskii deleted the fix-memory-leak-next branch October 24, 2022 13:35
@JJ810 JJ810 mentioned this pull request Oct 28, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! performance regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cherniavskii @mui-bot