Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Rework localization doc pages #6625

Merged
merged 106 commits into from
Nov 30, 2022
Merged

[docs] Rework localization doc pages #6625

merged 106 commits into from
Nov 30, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Oct 25, 2022 •
edited
Loading

Doc preview

Closes #5076

I am not 100% convinced by the name of the page and the folder.
I do think we need to split into several pages and that all those topic are tightly related.

New structure

We now have 3 pages

  • Library to manipulate dates => if you have a better name, I try to avoid the term "Adapter" because the target here is beginner starting with the library and they won't know this term. This page should be summarized in Getting Started just like today with a like "to learn more*

  • Localized dates

  • Translated components

@mui-bot
Copy link

mui-bot commented Oct 25, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-6625--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 833.2 1,310.9 833.2 1,042.04 210.89
Sort 100k rows ms 846.9 1,367.4 1,077.9 1,070.24 168.266
Select 100k rows ms 256.6 321.9 317.1 296.08 29.467
Deselect 100k rows ms 173.4 344.3 234.1 241.56 64.102

Generated by 🚫 dangerJS against 9c74749

@zannager zannager added the docs Improvements or additions to the documentation label Oct 25, 2022
@flaviendelangle flaviendelangle self-assigned this Oct 26, 2022
@oliviertassinari oliviertassinari removed the request for review from siriwatknp October 26, 2022 14:43
@oliviertassinari oliviertassinari added the component: pickers This is the name of the generic UI component, not the React module! label Oct 26, 2022
@flaviendelangle flaviendelangle mentioned this pull request Oct 27, 2022
Merged
@flaviendelangle flaviendelangle mentioned this pull request Nov 3, 2022
Closed
2 tasks
@flaviendelangle flaviendelangle mentioned this pull request Nov 15, 2022
Merged
flaviendelangle and others added 24 commits November 29, 2022 13:26
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/adapters-locale/adapters-locale.md
0cf15c0 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/adapters-locale/adapters-locale.md
040f3f1 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/adapters-locale/adapters-locale.md
bf2f6ba 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/adapters-locale/adapters-locale.md
3ad7423 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/adapters-locale/adapters-locale.md
a0a3709 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/getting-started/getting-started.md
6f9ae8f 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/adapters-locale/adapters-locale.md
98cdbf9 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/adapters-locale/adapters-locale.md
716faf5 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/adapters-locale/adapters-locale.md
f33bbbc 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/getting-started/getting-started.md
a6f068a 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/adapters-locale/adapters-locale.md
250632e 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/calendar-systems/calendar-systems.md
d5a45cb 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/calendar-systems/calendar-systems.md
c5c0ea8 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/calendar-systems/calendar-systems.md
7b3cd00 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/calendar-systems/calendar-systems.md
9cca285 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/calendar-systems/calendar-systems.md
fd6297d 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/adapters-locale/adapters-locale.md
e7b992e 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/getting-started/getting-started.md
8e6598d 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/getting-started/getting-started.md
515d574 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/getting-started/getting-started.md
48db4fc 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/localization/localization.md
c3f5f2f 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/localization/localization.md
d63f6d9 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Update docs/data/date-pickers/localization/localization.md
433c50f 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle @samuelsycamore
Apply suggestions from code review
e00442a 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle
Copy link
Member Author

I'll merge this one
I think everyone will agree that it's already an improvement compared to what is live, we can improve it in follow up if you want.

@flaviendelangle flaviendelangle merged commit f5c4964 into mui:next Nov 30, 2022
@flaviendelangle flaviendelangle deleted the docs-localization branch November 30, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@LukasTy LukasTy LukasTy approved these changes

@m4theushw m4theushw m4theushw left review comments

@joserodolfofreitas joserodolfofreitas Awaiting requested review from joserodolfofreitas

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

@samuelsycamore samuelsycamore Awaiting requested review from samuelsycamore

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs][pickers] Document the bundle size impact of the various adapters
8 participants
@flaviendelangle @mui-bot @oliviertassinari @LukasTy @m4theushw @alexfauquette @samuelsycamore @zannager