Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix typescript:ci failures #6705

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Nov 1, 2022

A follow up on #6381 (review) due to again consistently failing tsc

Try not to use nx as a runner as it seems to also solve the problem as well as reducing concurrency even lower.

@LukasTy LukasTy added the core Infrastructure work going on behind the scenes label Nov 1, 2022
@mui-bot
Copy link

mui-bot commented Nov 1, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6705--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 1,124.2 1,534.2 1,288.7 1,283.68 152.04
Sort 100k rows ms 1,042 1,535.9 1,460.5 1,360.16 182.997
Select 100k rows ms 337.7 513.3 413.1 415.26 56.59
Deselect 100k rows ms 220.4 570.2 297.2 329.08 124.082

Generated by 🚫 dangerJS against 8324d3a

@cherniavskii
Copy link
Member

I think I have the same issue in #6707 (comment)
https://app.circleci.com/pipelines/github/mui/mui-x/27010/workflows/4ff804a5-aeff-4654-be7b-ca15667edc43/jobs/155299

@cherniavskii
Copy link
Member

It might be caused by the recent lerna upgrade #6533 and the fact that nx is now used by default.
We can try adding "useNx": false in lerna.json

@LukasTy
Copy link
Member Author

LukasTy commented Nov 1, 2022

@cherniavskii It seems to have also solved the problem.
The only difference is that it is slower by a few seconds than 5 concurrent runners with nx. 😃

Done in 95.91s.
Done in 100.80s.

@LukasTy LukasTy changed the title [core] Try fixing typescript:ci [core] Fix typescript:ci failures Nov 1, 2022
@LukasTy LukasTy marked this pull request as ready for review November 1, 2022 18:46
@cherniavskii
Copy link
Member

The only difference is that it is slower by a few seconds than 5 concurrent runners with nx.

If we stick with nx, it will also be used for publishing packages.
For now, I would propose disabling it to avoid potential issues in the release process.
We can explore nx later.

@cherniavskii cherniavskii merged commit b43bbc7 into mui:next Nov 1, 2022
@LukasTy LukasTy deleted the try-fix-typescript-ci branch November 2, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants