Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix API page ad space regression #7051

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 30, 2022

Apply mui/material-ui#35201 in MUI X.

Before: https://next.mui.com/x/api/data-grid/data-grid/
After: https://deploy-preview-7051--material-ui-x.netlify.app/x/api/data-grid/data-grid/


We should be able to remove this duplication of the ApiPage component as we move forward. It feels like we introduced debt when we decided to fork the file. The current diff now between the mono repo and MUI X seems to be about:

mui/material-ui#35202 will also need to be applied twice. The same will happen with mui/material-ui#34085.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Nov 30, 2022
@mui-bot
Copy link

mui-bot commented Nov 30, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-7051--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 722.5 1,210.4 722.5 908.38 192.469
Sort 100k rows ms 663.1 1,396 1,396 1,033.08 251.493
Select 100k rows ms 208.9 495.8 298.3 309.92 101.972
Deselect 100k rows ms 159.7 291.3 176.9 208.02 49.587

Generated by 🚫 dangerJS against 5b77c9c

@oliviertassinari oliviertassinari merged commit 4f70faf into mui:next Dec 1, 2022
@oliviertassinari oliviertassinari deleted the fix-dark-mode-ad-gap branch December 1, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants