-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Add tests for DataGrid filtering feature #715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing works! It works in storybook though
In this case, I would encourage we take it more slowly. We can do the test refactoring and the new test in two different PRs.
Still WIP but you can have a quick look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the refactoring of the tests to a different PR. We are changing tests and source at the same time, we should be able to see what impacts what
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit 1704ebd
Great, we go from 30 tests (2.5s) to 53 tests (4s). The tests run fast enough. We should be able to add x10 more without having to change anything in the infrastructure. I only hope that it won't get slower as we add more features in the data grid. |
No description provided.