Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Polish refactor #723

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 11, 2020

A continuation on #722, the changes:

  • XGrid extends DataGrid. Tests that cover both should be at the DataGrid level.
  • imports from @testing-library/react are not allowed, we proxy them all with test/utils. I have added an eslint rule to fail the CI and had to switch a test to strict: false, this test doesn't work in strict mode. It's important we know about it, the underlying logic of the grid is likey incorrect.
  • Blank line convention between two different tests.
  • We don't do ../../.., we use absolute imports from the root for simplicity.
  • Move XGrid tests under a /tests folder for consistency with DataGrid.
  • No empty space at the end of test block descriptions.
  • We don't allow imports from test/utils/index in the main repo. I have added an eslint rule to fail the CI for consistency.
  • Remove orphan async () => {.

Motived by seeing the same issues in #715, this PR should come before #715.

@oliviertassinari oliviertassinari merged commit ca9b34a into mui:master Dec 14, 2020
@oliviertassinari oliviertassinari deleted the clean-up branch December 14, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants