Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update Data Grid demo to v6-beta #7863

Merged

Conversation

joserodolfofreitas
Copy link
Member

@joserodolfofreitas joserodolfofreitas commented Feb 8, 2023

Summary

  • Fix typo on Aggregation.
  • Add Column Menu and Cell Selection to the demo list.

Preview

https://deploy-preview-7863--material-ui-x.netlify.app/x/react-data-grid/demo/

@joserodolfofreitas joserodolfofreitas changed the title [docs] Update demo to v6beta [docs] Update Data Grid demo to v6beta Feb 8, 2023
@joserodolfofreitas joserodolfofreitas changed the title [docs] Update Data Grid demo to v6beta [docs] Update Data Grid demo to v6-beta Feb 8, 2023
@mui-bot
Copy link

mui-bot commented Feb 8, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-7863--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 718.3 1,267 718.3 941.66 197.65
Sort 100k rows ms 758.4 1,305.9 1,225.3 1,076.58 190.55
Select 100k rows ms 175.5 308.4 237.7 241.58 42.693
Deselect 100k rows ms 205.3 358.5 225.5 263.62 61.973

Generated by 🚫 dangerJS against 13d54b4

@zannager zannager added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Feb 9, 2023
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 🎉

A very minor nitpick for some future PR, as the list grows, it might be a little bit difficult to scroll to the desired feature (if a user decides not to use search), maybe it will make dx slightly better by sorting them alphabetically (also maintaining the package order).

@@ -169,6 +168,25 @@ export const featuresSet = [
detailPage: '/tree-data/',
demo: <TreeDataFullExample />,
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add it to the v5 doc with a link to v6 and a small note ?

joserodolfofreitas and others added 3 commits March 1, 2023 19:19
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Signed-off-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Signed-off-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
@joserodolfofreitas joserodolfofreitas merged commit c793742 into mui:next Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants