Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

[FIX]:Solve issue #89 for filtering the tags. #103

Closed
wants to merge 1 commit into from

Conversation

ajaychauhan727
Copy link

  • solve filter issue
  • Made domain apply from on_change to solve the issue

@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #103 into 12.0 will decrease coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             12.0    #103     +/-   ##
========================================
- Coverage   81.79%   81.6%   -0.2%     
========================================
  Files          39      39             
  Lines        1692    1696      +4     
========================================
  Hits         1384    1384             
- Misses        308     312      +4
Impacted Files Coverage Δ
muk_dms/models/file.py 84.19% <0%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0198265...77abefc. Read the comment docs.

@keshrath
Copy link
Member

keshrath commented Jul 5, 2019

Thanks for your PR. Since we don't use Github directly as development tool, but only as community portal, I can't accept it directly, as otherwise our CI workflow won't work. However, I have inserted and published your changes.

Commit: cb30e29

@keshrath keshrath closed this Jul 5, 2019
@ajaychauhan727
Copy link
Author

@keshrath Thanks for the update. Please let me know if I can contribute to your projects with your preferred workflow.

@keshrath
Copy link
Member

keshrath commented Jul 8, 2019

The PRs on Github are absolutely fine. If there are so many that it takes too much time to copy them manually, I'll just script it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants