Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated api version to 5.62 #145

Merged
merged 2 commits into from Nov 22, 2021
Merged

updated api version to 5.62 #145

merged 2 commits into from Nov 22, 2021

Conversation

OrgansWithoutBodies
Copy link
Contributor

@OrgansWithoutBodies OrgansWithoutBodies commented Nov 21, 2021

Hoping this fixes #143, not super familiar with Go but this seems to add the proper prop to this struct - as an extra plus this is the change in bluez that added this prop https://patchwork.kernel.org/project/bluetooth/patch/20210826164211.2936133-1-david@lechnology.com/ EDIT: ah seems i misunderstood the structure of this project, added 5.62 to version generation

@OrgansWithoutBodies OrgansWithoutBodies changed the title added MTU to DeviceProperties updated api version to 5.62 Nov 22, 2021
@muka
Copy link
Owner

muka commented Nov 22, 2021

Hi thank you for the PR! Being an API change the flow is to regenerate the go code from the API docs of blues.
I have not yet had time to review but Is this the way your are approaching in the PR?

@OrgansWithoutBodies
Copy link
Contributor Author

OrgansWithoutBodies commented Nov 22, 2021

@muka yeah, the first commit (d41bd28) was by-hand before I grok'ed the structure of this project, the second (c010b71) I removed that change & ran BLUEZ_VERSION=5.62 make gen/clean gen & added that to the makefile

@muka muka merged commit b99792b into muka:master Nov 22, 2021
@muka
Copy link
Owner

muka commented Nov 22, 2021

Great @OrgansWithoutBodies thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapToStruct: Field not found: MTU
2 participants