Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W-15051462] fix minor bug for breadcrumbs + reorganize JP preview site #725

Merged
merged 3 commits into from
May 30, 2024
Merged

[W-15051462] fix minor bug for breadcrumbs + reorganize JP preview site #725

merged 3 commits into from
May 30, 2024

Conversation

cheungaryk
Copy link
Contributor

ref: W-15051462

  • fix minor issue for breadcrumbs so if the breadcrumbs aren't present on the site (for example, in the homepage), the script doesn't need to execute further
  • move the JP preview site files into the correct location so the preview site can find them
  • update header

@cheungaryk cheungaryk requested a review from a team May 30, 2024 14:12
@cheungaryk cheungaryk requested a review from a team as a code owner May 30, 2024 14:12
jdomingu
jdomingu approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@jdomingu jdomingu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Confirmed this locally. Merge away!

Probably unrelated: Do you see this in the trending topics recs on your end?

Screenshot 2024-05-30 at 10 45 00 AM

@cheungaryk cheungaryk merged commit fefc343 into main May 30, 2024
7 checks passed
@cheungaryk cheungaryk deleted the W-15051462-fix-jp-bug-gc branch May 30, 2024 17:52
@cheungaryk
Copy link
Contributor Author

Looks good! Confirmed this locally. Merge away!

Probably unrelated: Do you see this in the trending topics recs on your end?

Screenshot 2024-05-30 at 10 45 00 AM

Great! Thanks for the approval. The issue with the "no title" error is due to the incident with the JP redirect. Once that issue is resolved, this issue will be resolved as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdomingu jdomingu jdomingu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cheungaryk @jdomingu