Add CppUTest support #750
Merged
Add CppUTest support #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @OMantere, thanks for the PR. There are some weird failures I'm trying to debug right now. What I see is that CppUTest re-defines operators |
|
All right, the memory leak thing can be disabled with the following change: diff --git a/vendor/CMakeLists.txt b/vendor/CMakeLists.txt
index 0f1d1b7..971d486 100644
--- a/vendor/CMakeLists.txt
+++ b/vendor/CMakeLists.txt
@@ -1,3 +1,7 @@
add_subdirectory(json11 EXCLUDE_FROM_ALL)
add_subdirectory(LibEBC EXCLUDE_FROM_ALL)
+
add_subdirectory(cpputest EXCLUDE_FROM_ALL)
+target_compile_definitions(CppUTest
+ PRIVATE CPPUTEST_MEM_LEAK_DETECTION_DISABLED
+)This should make CI green, and we'll be ready for merge. |
|
@AlexDenisov Thanks for the change! I applied it in commit |
|
CI is off again, but I'll fix it separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the CppUTest test framework (http://cpputest.github.io)