Set in MOE 2.0 GraalVM as jdk instead of moe

[Berstanio]

This is currently only enabled for moe 2.0. I tested it a bit and it seems to work fine. Theoretical if I didn't missed anything we could also remove the whole sdk creation etc. also for MOE 1.9 and set directly the jdk which would be otherwise just wrapped.
(I also fixed some NPE bugs.)
Relatded prs: multi-os-engine/moe-plugin-gradle#10 multi-os-engine/moe-tools-common#2

[Noisyfox]

I think we could add a "version" property to the gradle model, so we can handle SDK differently.

[Berstanio]

Should this still be done?

[Berstanio]

I would also rework this so that in any case the project jdk is set, except for MOE 2.0 where GraalVM is set as jdk.
Using the moe sdk as jdk just leads to trouble and doesn't have any benefits as far as I'm aware.
Any objections?

[Noisyfox]

I'd like to keep the MOE SDK type for moe 1.x project, because if the moe 1.x module is set to use a normal JDK, then in the IDE this module will contain classes from both MOE 1.x sdk (from Gradle dependencies) and the JDK you selected in IntelliJ module settings, so the auto completion will show you classes that's available from JDK but not available in MOE. The purpose of having a MOE sdk type is to get rid of classes from a normal JDK.

For 2.x I do agree that having a MOE sdk type is useless and we should set the GraalVM as the module JDK.

[Noisyfox]

There is one thing I did wrong and need to fix first is the way of determine the JDK to run the build. I used the module JDK which causes a lot of problems. What I should be using is the JDK set in IDE Gradle settings instead.

[Berstanio]

I'd like to keep the MOE SDK type for moe 1.x project, because if the moe 1.x module is set to use a normal JDK, then in the IDE this module will contain classes from both MOE 1.x sdk (from Gradle dependencies) and the JDK you selected in IntelliJ module settings, so the auto completion will show you classes that's available from JDK but not available in MOE. The purpose of having a MOE sdk type is to get rid of classes from a normal JDK.

Ahh, okay, I see! The reason why I wanted to remove it on 1.x too was, that I got the following error after a gradle sync, when running a build with the IDEA plugin: "Multi-OS Engine module build failedError while building Module SDK not configured or it's not a valid JDK ."

There is one thing I did wrong and need to fix first is the way of determine the JDK to run the build. I used the module JDK which causes a lot of problems. What I should be using is the JDK set in IDE Gradle settings instead.

Is the issue above also fixed by that?

[Noisyfox]

"Multi-OS Engine module build failedError while building Module SDK not configured or it's not a valid JDK ."

Yep that's the exact issue I'm talking about.

[Noisyfox]

I'll include this in #8 with a few changes