Use Gradle jdk to run MOE build #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Berstanio Could you give this a try and see if this solves the "Module SDK not configured or it's not a valid JDK" issue? |
|
#7 already fixed the issue for me. But I will check this changes out too |
|
FYI this will break the plugin with MOE 2.0 though because it won't set the GraalVM as the module SDK. I'll try to figure out how to put #6 into this. Currently this update will force setting the module SDK to MOE everything you resync the gradle project. This need to be disabled for MOE 2.x to allow user to change the module SDK. |
The changes work fine for me! |
Berstanio
reviewed
Jul 18, 2022
* commit '87d220fbcc52dab8517e67d67520658e1cb6a2a4': Set graalvm as sdk when possible # Conflicts: # src/main/java/org/moe/idea/sdk/MOESdkType.java # src/main/kotlin/org/moe/idea/model/impl/MOESdkPropertiesImpl.kt
…d as module SDK. Fix SDK naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses Gradle JDK to execute build commands, so we don't need to mess around with the MOE SDK. This is particularly useful in Android Studio when you have both Android and iOS module in a single project, as the Android Studio's module settings dialog is a minified version that does not allow you to modify module JDK settings.