-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new multiformats #45
Conversation
makes it clear that the value is (digest, in specific multibase)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hacdias thank you! ❤️
CircleCI cleanup is tracked in #46, should not block this PR.
I think we should prioritize shipping this, and move "Perhaps web worker or something to update multiformats table periodically" to a separate issue/PR. Quick note: let's have GithubAction (CI) that updates codecs.json daily than client-side code that sends HTTP requests to GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hacdias it seems to fail with CIDv0: QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR
– mind taking a look?
A small commit to test #46
@lidel should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
errorRecovery
option instead.After this PR