Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the default length of the ID hash function to -1 #55

Merged
merged 1 commit into from Jul 13, 2017
Merged

Set the default length of the ID hash function to -1 #55

merged 1 commit into from Jul 13, 2017

Conversation

Stebalien
Copy link
Member

Truncating to 32bits by default is a bit arbitrary and is guaranteed to make unsuspecting users very unhappy.

@Stebalien
Set the default length of the ID hash function to -1
710ff25 
Truncating to 32bits by default is a bit arbitrary and is guaranteed to make
unsuspecting users very unhappy.
@Stebalien
Copy link
Member Author

@JustinDrake, @Kubuxu, @lgierth

Is this reasonable?

Kubuxu
Kubuxu approved these changes Jul 13, 2017
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for me.

@Stebalien Stebalien mentioned this pull request Jul 13, 2017
Closed
@Kubuxu Kubuxu merged commit f1ef5a0 into multiformats:master Jul 13, 2017
@JustinDrake
Copy link
Contributor

LGTM 👍

@kevina kevina mentioned this pull request Nov 28, 2017
Closed
@Stebalien Stebalien deleted the id-hash-length branch November 29, 2017 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stebalien @JustinDrake @Kubuxu