Store the multihash length as an uint32. #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some code constructs prefixes with negative lengths which means: 1. `cid1.Bytes() == cid2.Bytes()` does not imply `cid1.Prefix() == cid2.Prefix()`. 2. `Prefix.Bytes()` is broken. This commit fixes those issues by simply forbidding negative hash lengths in `Prefix` and providing nice constructors that lookup the default hash length. This is clearly a breaking change.
|
So, one problem with this solution is that not all hash functions have a reasonable default length (e.g., ID). See multiformats/go-multihash#55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code constructs prefixes with negative lengths which means:
cid1.Bytes() == cid2.Bytes()does not implycid1.Prefix() == cid2.Prefix().Prefix.Bytes()is broken.This commit fixes those issues by simply forbidding negative hash lengths in
Prefixand providing nice constructors that lookup the default hashNote: This also includes a 0.8.0 release to indicate that it breaks the API a bit.
Note2: It would be nice if the go-multihash used uint32 instead of int for hash lengths but fixing that is leads to a rats nest of problems stemming from the fact that:
lenreturns anint.Sumaccepts-1as a length.