This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
fix: explicitly require .json ext of base-table #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Furthermore, without this fix, loading this module from a webpack production bundle fails for me. Please merge this in as soon as possible. |
hiddentao
added a commit
to solui/js-ipfs-http-client
that referenced
this pull request
Jan 11, 2020
mikeal
approved these changes
Jan 13, 2020
vmx
force-pushed
the
rvagg/json-require
branch
from
8b7f257
to
7de5bd4
Compare
|
I was already reviewed, I just rebased it, hence merging it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96
this is good practice anyway