Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /webrtc and /certhash #261

Closed
John-LittleBearLabs opened this issue Aug 9, 2022 · 2 comments · Fixed by #262
Closed

Add /webrtc and /certhash #261

John-LittleBearLabs opened this issue Aug 9, 2022 · 2 comments · Fixed by #262

Comments

@John-LittleBearLabs
Copy link
Contributor

Analagous to the rust implementation:
https://github.com/multiformats/rust-multiaddr/pull/59/files#diff-d8c31d407e43532e4152070bdaf92d7fff58c81b39b4308cad7c769519d31376
And to the go implementation:
https://github.com/multiformats/go-multiaddr/pull/179/files

The goal is to be able to examine and use multiaddrs with these protocols in browserland, too.
Will be useful to the js/ts implementation of the transport.

For reference:
libp2p/specs#412
@ddimaria
Copy link

ddimaria commented Aug 9, 2022

@John-LittleBearLabs Can I move this to Ready, In Progress, or In Review? I think I saw you post on slack about a PR for this.

@John-LittleBearLabs
Copy link
Contributor Author

@John-LittleBearLabs Can I move this to Ready, In Progress, or In Review? I think I saw you post on slack about a PR for this.

@ddimaria
I do not have a PR for it yet. In fact the code change I have locally at the moment does not work properly, and I can prove it.

But perhaps "In Progress" isn't unreasonable.

John-LittleBearLabs added a commit to little-bear-labs/js-multiaddr that referenced this issue Aug 9, 2022
@John-LittleBearLabs
fix: Add support for webrtc and certhash (multiformats#261)
5ea7b52
@mxinden mxinden mentioned this issue Aug 19, 2022
Merged
@mxinden mxinden linked a pull request Aug 19, 2022 that will close this issue
feat: add support for webrtc and certhash (#261) #262
Merged
achingbrain pushed a commit that referenced this issue Aug 30, 2022
@John-LittleBearLabs
feat: add support for webrtc and certhash (#261) (#262)
e5a8e27 
For use with the js implementation of the webrtc transport

The most relevant point of info, from [the draft spec](https://github.com/libp2p/specs/blob/4b8e890c49061eb62c9d16a9afd3aa0a738e6285/webrtc/README.md#addressing): 

> The TLS certificate fingerprint in /certhash is a [multibase](https://github.com/multiformats/multibase) encoded [multihash](https://github.com/multiformats/multihash).
github-actions bot pushed a commit that referenced this issue Aug 30, 2022
@semantic-release-bot
chore(release): 10.4.0 [skip ci]
3997999 
## [10.4.0](v10.3.5...v10.4.0) (2022-08-30)

### Features

* add support for webrtc and certhash ([#261](#261)) ([#262](#262)) ([e5a8e27](e5a8e27))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for webrtc and certhash (#261) little-bear-labs/js-multiaddr
2 participants
@ddimaria @John-LittleBearLabs