update/match go multiaddr #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +42,7 @@ Multiaddr.prototype.toOptions = function toOptions () { | |||
|
|
|||
| // get the multiaddr protocols | |||
| Multiaddr.prototype.inspect = function inspect () { | |||
| return '<Mutliaddr ' + | |||
| return '<Multiaddr ' + | |||
There was a problem hiding this comment.
|
Would be nice to have CI run on this, no idea if linting + tests are actually passing, but if they do LGTM |
daviddias
force-pushed
the
update/match-go-multiaddr
branch
from
f376bed
to
f64144e
Compare
|
@dignifiedquire agree, I've opened an issue for it, waiting on @jbenet #8 But I can assure you that the tests run on my machine™ :D |
| var convert = require('./convert') | ||
| var protocols = require('./protocols') | ||
| var varint = require('varint') |
There was a problem hiding this comment.
nice, implementation of varints. we should make go-multiaddr have them too.
There was a problem hiding this comment.
doesn't go-multiaddr have varints for a long time? -> https://github.com/jbenet/go-multiaddr/blob/master/codec.go#L75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.