Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

Use fixed version of nodeify #18

Merged
merged 3 commits into from
Feb 26, 2017
Merged

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Feb 25, 2017

The 1.0.0 version has an ugly bug: then/nodeify#2

The 1.0.0 version has an ugly bug: then/nodeify#2
mitar added a commit to mitar/js-ipld-dag-cbor that referenced this pull request Feb 25, 2017
Copy link

@tabrath tabrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks the build

package.json Outdated
@@ -42,7 +42,7 @@
"js-sha3": "^0.5.7",
"multihashes": "~0.4.3",
"murmurhash3js": "^3.0.1",
"nodeify": "^1.0.0"
"nodeify": "git+ssh://git@github.com/then/nodeify.git#444f8a68890fd08b9b30113784833283c61d277e"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work and breaks the build. Should be git://github.com/then/nodeify.git#444f8a68890fd08b9b30113784833283c61d277e

@mitar
Copy link
Contributor Author

mitar commented Feb 25, 2017

Changed.

@mitar
Copy link
Contributor Author

mitar commented Feb 26, 2017

1.0.1 version has been released.

@dignifiedquire
Copy link
Member

Thank you :octocat:

@dignifiedquire dignifiedquire merged commit 154001d into multiformats:master Feb 26, 2017
@mitar mitar deleted the patch-1 branch February 27, 2017 02:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants