-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RSA public key (x.509 Encoded) #195
Conversation
I think we're trying to avoid assigning single-byte entries as much as possible. Perhaps this might rise above the bar, although I don't really have a feel for where that bar might be and how close this comes to it. @Stebalien @vmx, thoughts? |
To me the bar for single byte entries is. Would it be a problem to put it into the 2-bytes (or more) range? If the answer is "why not", then definitely put it into that other range. @b5 Is there a reason why it needs to be in the single byte range, or could it well be in some other range? |
@jonnycrunch just adding myself to the discussion as a reminder that is cool stuff @b5 and I need to understand it more! |
No reason at all it needs to be in the single byte range. Given the use case is mostly around migration, I agree it makes more sense to use the two byte (or more range). I mainly kicked this PR off to get this discussion going, and would welcome a byte assignment from spec maintainers. At the risk of being presumptuous, I think RSA is starting to lose favourability in circles that will be interested in multiformats, (even in our case we're interested in this multicodec so we can transition to Edwards curve keys), so I fully agree it should move to the 2 bytes or more range. If others don't have a suggestion in the next day or two I'll pick something in the 2 byte range to keep the conversation moving, but I'd much prefer to be told what works here :) |
We have a block in |
@b5 just moving the conversation back here. I'd love to see this get merged; we depend on RSA for |
Should be good to land if we move it up into the 0x12xx and rebase to current master. |
superseded by #226 |
Add a prefix for raw (not libp2p) x.509 public key bytes. I think we should have this for a parity with other public key formats.
It's worth adding now because it'll make writing code that does key rotation from RSA -> ED25519 with open standards possible.
Regarding the
0x5d
prefix There's a W3C working group draft spec floating out in the wild that would require this addition to make RSA keys work, and this issue makes reference to0x5d
as the chosen prefix. I've reused this value here to be just slightly above picking at random.