Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add webrtc to multiaddr #279

Merged
merged 2 commits into from
Jul 15, 2022
Merged

add webrtc to multiaddr #279

merged 2 commits into from
Jul 15, 2022

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Jul 13, 2022

@melekes melekes mentioned this pull request Jul 13, 2022
Merged
marten-seemann
marten-seemann reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a different value than the one in multiformats/multiaddr#131?

@melekes
Copy link
Contributor Author

melekes commented Jul 13, 2022

Why is this a different value than the one in multiformats/multiaddr#131?

wasn't sure how code issuance works. changed to 280

mxinden
mxinden approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @melekes.

I am not a maintainer of this repository. @rvagg @Stebalien are you fine with us merging here?

@rvagg
Copy link
Member

rvagg commented Jul 15, 2022

@mxinden @marten-seemann yeap, you have pretty much free-range on the multiaddr entries as far as I'm concerned, as long as you don't stray too low and get into the precious single-byte range <= 0x7f and keep the validation script happy. Go ahead and merge both of these if they're good to go.

@mxinden mxinden merged commit 2ebc661 into multiformats:master Jul 15, 2022
@melekes melekes deleted the webrtc branch July 15, 2022 07:31
@mxinden mxinden mentioned this pull request Jul 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@melekes @rvagg @marten-seemann @mxinden