-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added multicodec-packed beginning #9
Conversation
The table is still missing.
LGTM! |
LGTM as well :) Thank you! |
```sh | ||
code codec | ||
0x00 raw binary data | ||
0x40 multicodec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is (0x40) self referencing. Is the idea to use this when a packed-multicodec does not describe the data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this meant regular multicodec, not mutlicodec-packed
I have one question. Other than that it LGTM. |
Okay, i'm going to merge this. we can work on the table next. |
The table is still missing.