added multicodec-packed beginning #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The table is still missing.
This was referenced Aug 25, 2016
Closed
|
LGTM! |
|
LGTM as well :) Thank you! |
| ```sh | ||
| code codec | ||
| 0x00 raw binary data | ||
| 0x40 multicodec |
There was a problem hiding this comment.
This is (0x40) self referencing. Is the idea to use this when a packed-multicodec does not describe the data?
There was a problem hiding this comment.
this meant regular multicodec, not mutlicodec-packed
|
I have one question. Other than that it LGTM. |
|
Okay, i'm going to merge this. we can work on the table next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table is still missing.