Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multilingual functionality to the site #3

Merged
merged 5 commits into from
Nov 17, 2019

Conversation

JonathanReeve
Copy link
Collaborator

This adds i18n functionality to the site, allowing the user to switch between languages. I google-translated the site content in some places to start it off.

I also changed the default language away from English. The way I see it, if DH is too English-centric, why not set a good example by avoiding anglocentrism on the website, too? I changed it to Esperanto, the most commonly spoken neutral language, so as to avoid implicitly privileging any particular national language. This is an unusual choice, but I think you'll agree that it's a bold statement that critiques the dominance of the English language on the Internet.

The theme has some changes, because the Jekyll theme that was there previously didn't play nicely with this setup. But that's a good thing, since the codebase is now much smaller, and the site is much more maintainable. This is easy to change, though—for instance, with a drop-in CSS framework like Bulma. Or better yet, just by adding a couple of lines of style to the SASS.

Let me know what you think! You can preview this PR at https://jonathanreeve.github.io/multilingual-dh.github.io/.

Copy link
Member

@quinnanya quinnanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing all this! It's been a huge roadblock. I was going to try to sort it out with Alex Gil next week, but it's amazing to have help with it.

@quinnanya quinnanya merged commit 58c7594 into multilingual-dh:master Nov 17, 2019
@JonathanReeve
Copy link
Collaborator Author

Happy to help! Thanks for merging.

@shuiowa
Copy link

shuiowa commented Nov 19, 2019

Hello, I may contribute a Chinese edition to the "manifesto", if you don't mind.

@quinnanya
Copy link
Member

That would be wonderful, thank you! Would it work for you to submit a pull request with the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants