Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netlink: switch to YAML Netlink specs #340

Closed
matttbe opened this issue Jan 27, 2023 · 1 comment
Closed

netlink: switch to YAML Netlink specs #340

matttbe opened this issue Jan 27, 2023 · 1 comment
Assignees
@dcaratti
Labels
enhancement
Projects
MPTCP Next (6.4)

Comments

@matttbe
Copy link
Member

matttbe commented Jan 27, 2023

This is linked to Jakub series and his presentation at LPC2022.

The specs are defined in YAML to help on different topics.
@matttbe matttbe added this to Needs triage in MPTCP Future via automation Jan 27, 2023
@dcaratti dcaratti self-assigned this Feb 7, 2023
@matttbe matttbe removed this from Needs triage in MPTCP Future Feb 22, 2023
@matttbe matttbe added this to To do in MPTCP Next (6.4) via automation Feb 22, 2023
@dcaratti
Copy link
Contributor

dcaratti commented Jun 6, 2023

it seems that we are using "global" policy, but ops use (at least) 2 different attribute-sets. In the RFC post [1] I was defaulting everything to "attr". In this way, the code generated from yaml spec is the same as what we have in the current "export" branch; however, it would be better to convert to per-op first, and then use a yaml spec that doesn't specify "global". In this way, we would have more accurate validation

[1] https://lore.kernel.org/mptcp/cb2ed01dd8797078c39c014e8c19eab5ddf1f0f2.1680801697.git.dcaratti@redhat.com/

intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Jun 9, 2023
@dcaratti @intel-lab-lkp
mptcp: convert netlink from small_ops to ops
bd0c2e4 
this prepares MPTCP control plane to be described as YAML spec.

Link: multipath-tcp/mptcp_net-next#340
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Jun 12, 2023
@dcaratti @intel-lab-lkp
mptcp: convert netlink from small_ops to ops
ebe387f 
this prepares MPTCP control plane to be described as YAML spec.

Link: multipath-tcp/mptcp_net-next#340
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Jun 12, 2023
@dcaratti @intel-lab-lkp
mptcp: convert netlink from small_ops to ops
1fddb79 
this prepares MPTCP control plane to be described as YAML spec.

Link: multipath-tcp/mptcp_net-next#340
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Jun 27, 2023
@dcaratti @intel-lab-lkp
mptcp: convert netlink from small_ops to ops
7b2cb79 
this prepares MPTCP control plane to be described as YAML spec.

Link: multipath-tcp/mptcp_net-next#340
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Sep 20, 2023
@dcaratti @intel-lab-lkp
net: mptcp: convert netlink from small_ops to ops
4079e98 
in the current MPTCP control plane, all operations use a netlink
attribute of the same type "MPTCP_PM_ATTR". However, add/del/get/flush
operations only parse the first element in the message _ the one that
describes MPTCP endpoints (that was named MPTCP_PM_ATTR_ADDR and
mostly used in ADD_ADDR operations _ probably the similarity of "attr",
"addr" and "add" might cause some confusion to human readers).
Convert MPTCP from 'small_ops' to 'ops', thus allowing different attributes
for each single operation, hopefully makes all this clearer to human
readers.

- use a separate attribute set for add/del/get/flush address operation,
  binary compatible with the existing one, to store the endpoint address.
  MPTCP_PM_ENDPOINT_ADDR is added to the uAPI (with the same value as
  MPTCP_PM_ATTR_ADDR) for these operations.
- convert mptcp_pm_ops[] and add policy files accordingly.

this prepares MPTCP control plane to be described as YAML spec.

Link: multipath-tcp/mptcp_net-next#340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Sep 20, 2023
@dcaratti @intel-lab-lkp
Documentation: netlink: add a YAML spec for mptcp
5d8b8e7 
it describes most of the current netlink interface (uAPI definitions,
doit/dumpit operations and attributes)

Link: multipath-tcp/mptcp_net-next#340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Sep 20, 2023
@dcaratti @intel-lab-lkp
uapi: mptcp: use header file generated from YAML spec
f9171f0 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode uapi \
 > --spec Documentation/netlink/specs/mptcp.yaml \
 > --header -o include/uapi/linux/mptcp_pm.h

Link: multipath-tcp/mptcp_net-next#340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Sep 20, 2023
@dcaratti @intel-lab-lkp
net: mptcp: rename netlink handlers to mptcp_pm_nl_<blah>_{doit,dumpit}
5face0a 
so that they will match names generated from YAML spec.

Link: multipath-tcp/mptcp_net-next#340
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Sep 20, 2023
@dcaratti @intel-lab-lkp
net: mptcp: use policy generated by YAML spec
c873dd5 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --source \
 > -o net/mptcp/mptcp_pm_gen.c
 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --header \
 > -o net/mptcp/mptcp_pm_gen.h

Link: multipath-tcp/mptcp_net-next#340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
net: mptcp: convert netlink from small_ops to ops
34e8d83 
in the current MPTCP control plane, all operations use a netlink
attribute of the same type "MPTCP_PM_ATTR". However, add/del/get/flush
operations only parse the first element in the message _ the one that
describes MPTCP endpoints (that was named MPTCP_PM_ATTR_ADDR and
mostly used in ADD_ADDR operations _ probably the similarity of "attr",
"addr" and "add" might cause some confusion to human readers).
Convert MPTCP from 'small_ops' to 'ops', thus allowing different attributes
for each single operation, hopefully makes all this clearer to human
readers.

- use a separate attribute set for add/del/get/flush address operation,
  binary compatible with the existing one, to store the endpoint address.
  MPTCP_PM_ENDPOINT_ADDR is added to the uAPI (with the same value as
  MPTCP_PM_ATTR_ADDR) for these operations.
- convert mptcp_pm_ops[] and add policy files accordingly.

this prepares MPTCP control plane to be described as YAML spec.

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
Documentation: netlink: add a YAML spec for mptcp
cf4a7c6 
it describes most of the current netlink interface (uAPI definitions,
doit/dumpit operations and attributes)

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
uapi: mptcp: use header file generated from YAML spec
25385ac 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode uapi \
 > --spec Documentation/netlink/specs/mptcp.yaml \
 > --header -o include/uapi/linux/mptcp_pm.h

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
net: mptcp: rename netlink handlers to mptcp_pm_nl_<blah>_{doit,dumpit}
11351fc 
so that they will match names generated from YAML spec.

Link: #340
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
net: mptcp: use policy generated by YAML spec
7d081cf 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --source \
 > -o net/mptcp/mptcp_pm_gen.c
 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --header \
 > -o net/mptcp/mptcp_pm_gen.h

Closes: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
net: mptcp: convert netlink from small_ops to ops
f38fb24 
in the current MPTCP control plane, all operations use a netlink
attribute of the same type "MPTCP_PM_ATTR". However, add/del/get/flush
operations only parse the first element in the message _ the one that
describes MPTCP endpoints (that was named MPTCP_PM_ATTR_ADDR and
mostly used in ADD_ADDR operations _ probably the similarity of "attr",
"addr" and "add" might cause some confusion to human readers).
Convert MPTCP from 'small_ops' to 'ops', thus allowing different attributes
for each single operation, hopefully makes all this clearer to human
readers.

- use a separate attribute set for add/del/get/flush address operation,
  binary compatible with the existing one, to store the endpoint address.
  MPTCP_PM_ENDPOINT_ADDR is added to the uAPI (with the same value as
  MPTCP_PM_ATTR_ADDR) for these operations.
- convert mptcp_pm_ops[] and add policy files accordingly.

this prepares MPTCP control plane to be described as YAML spec.

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
Documentation: netlink: add a YAML spec for mptcp
1d23509 
it describes most of the current netlink interface (uAPI definitions,
doit/dumpit operations and attributes)

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
uapi: mptcp: use header file generated from YAML spec
d591147 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode uapi \
 > --spec Documentation/netlink/specs/mptcp.yaml \
 > --header -o include/uapi/linux/mptcp_pm.h

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
net: mptcp: rename netlink handlers to mptcp_pm_nl_<blah>_{doit,dumpit}
d2376aa 
so that they will match names generated from YAML spec.

Link: #340
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
net: mptcp: convert netlink from small_ops to ops
8054bdf 
in the current MPTCP control plane, all operations use a netlink
attribute of the same type "MPTCP_PM_ATTR". However, add/del/get/flush
operations only parse the first element in the message _ the one that
describes MPTCP endpoints (that was named MPTCP_PM_ATTR_ADDR and
mostly used in ADD_ADDR operations _ probably the similarity of "attr",
"addr" and "add" might cause some confusion to human readers).
Convert MPTCP from 'small_ops' to 'ops', thus allowing different attributes
for each single operation, hopefully makes all this clearer to human
readers.

- use a separate attribute set for add/del/get/flush address operation,
  binary compatible with the existing one, to store the endpoint address.
  MPTCP_PM_ENDPOINT_ADDR is added to the uAPI (with the same value as
  MPTCP_PM_ATTR_ADDR) for these operations.
- convert mptcp_pm_ops[] and add policy files accordingly.

this prepares MPTCP control plane to be described as YAML spec.

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
Documentation: netlink: add a YAML spec for mptcp
da33b45 
it describes most of the current netlink interface (uAPI definitions,
doit/dumpit operations and attributes)

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
uapi: mptcp: use header file generated from YAML spec
6bf563c 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode uapi \
 > --spec Documentation/netlink/specs/mptcp.yaml \
 > --header -o include/uapi/linux/mptcp_pm.h

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
net: mptcp: rename netlink handlers to mptcp_pm_nl_<blah>_{doit,dumpit}
0bf2e69 
so that they will match names generated from YAML spec.

Link: #340
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Sep 23, 2023
@dcaratti @matttbe
net: mptcp: use policy generated by YAML spec
bfd147f 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --source \
 > -o net/mptcp/mptcp_pm_gen.c
 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --header \
 > -o net/mptcp/mptcp_pm_gen.h

Closes: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
Documentation: netlink: add a YAML spec for mptcp
670cc66 
it describes most of the current netlink interface (uAPI definitions,
doit/dumpit operations and attributes)

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
uapi: mptcp: use header file generated from YAML spec
c7b6ff5 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode uapi \
 > --spec Documentation/netlink/specs/mptcp.yaml \
 > --header -o include/uapi/linux/mptcp_pm.h

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
net: mptcp: rename netlink handlers to mptcp_pm_nl_<blah>_{doit,dumpit}
70e01e7 
so that they will match names generated from YAML spec.

Link: #340
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
net: mptcp: use policy generated by YAML spec
607a651 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --source \
 > -o net/mptcp/mptcp_pm_gen.c
 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --header \
 > -o net/mptcp/mptcp_pm_gen.h

Closes: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
tools: ynl-gen: add support for exact-len validation
428bf00 
add support for 'exact-len' validation on netlink attributes.

Link: #340
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Acked-by: Matthieu Baerts <matttbe@kernel.org>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
net: mptcp: convert netlink from small_ops to ops
8bca730 
in the current MPTCP control plane, all operations use a netlink
attribute of the same type "MPTCP_PM_ATTR". However, add/del/get/flush
operations only parse the first element in the message _ the one that
describes MPTCP endpoints (that was named MPTCP_PM_ATTR_ADDR and
mostly used in ADD_ADDR operations _ probably the similarity of "attr",
"addr" and "add" might cause some confusion to human readers).
Convert MPTCP from 'small_ops' to 'ops', thus allowing different attributes
for each single operation, hopefully makes all this clearer to human
readers.

- use a separate attribute set for add/del/get/flush address operation,
  binary compatible with the existing one, to store the endpoint address.
  MPTCP_PM_ENDPOINT_ADDR is added to the uAPI (with the same value as
  MPTCP_PM_ATTR_ADDR) for these operations.
- convert mptcp_pm_ops[] and add policy files accordingly.

this prepares MPTCP control plane to be described as YAML spec.

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
Documentation: netlink: add a YAML spec for mptcp
e89ac52 
it describes most of the current netlink interface (uAPI definitions,
doit/dumpit operations and attributes)

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
uapi: mptcp: use header file generated from YAML spec
9da5433 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode uapi \
 > --spec Documentation/netlink/specs/mptcp.yaml \
 > --header -o include/uapi/linux/mptcp_pm.h

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
net: mptcp: rename netlink handlers to mptcp_pm_nl_<blah>_{doit,dumpit}
a892f77 
so that they will match names generated from YAML spec.

Link: #340
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
net: mptcp: use policy generated by YAML spec
bf15ae6 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --source \
 > -o net/mptcp/mptcp_pm_gen.c
 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --header \
 > -o net/mptcp/mptcp_pm_gen.h

Closes: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
tools: ynl-gen: add support for exact-len validation
95a0317 
add support for 'exact-len' validation on netlink attributes.

Link: #340
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Acked-by: Matthieu Baerts <matttbe@kernel.org>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
net: mptcp: convert netlink from small_ops to ops
851b935 
in the current MPTCP control plane, all operations use a netlink
attribute of the same type "MPTCP_PM_ATTR". However, add/del/get/flush
operations only parse the first element in the message _ the one that
describes MPTCP endpoints (that was named MPTCP_PM_ATTR_ADDR and
mostly used in ADD_ADDR operations _ probably the similarity of "attr",
"addr" and "add" might cause some confusion to human readers).
Convert MPTCP from 'small_ops' to 'ops', thus allowing different attributes
for each single operation, hopefully makes all this clearer to human
readers.

- use a separate attribute set for add/del/get/flush address operation,
  binary compatible with the existing one, to store the endpoint address.
  MPTCP_PM_ENDPOINT_ADDR is added to the uAPI (with the same value as
  MPTCP_PM_ATTR_ADDR) for these operations.
- convert mptcp_pm_ops[] and add policy files accordingly.

this prepares MPTCP control plane to be described as YAML spec.

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
Documentation: netlink: add a YAML spec for mptcp
b7569c8 
it describes most of the current netlink interface (uAPI definitions,
doit/dumpit operations and attributes)

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
uapi: mptcp: use header file generated from YAML spec
6333efc 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode uapi \
 > --spec Documentation/netlink/specs/mptcp.yaml \
 > --header -o include/uapi/linux/mptcp_pm.h

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
net: mptcp: rename netlink handlers to mptcp_pm_nl_<blah>_{doit,dumpit}
e307833 
so that they will match names generated from YAML spec.

Link: #340
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Oct 22, 2023
@dcaratti @matttbe
net: mptcp: use policy generated by YAML spec
ae3eee5 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --source \
 > -o net/mptcp/mptcp_pm_gen.c
 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --header \
 > -o net/mptcp/mptcp_pm_gen.h

Closes: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Oct 24, 2023
@dcaratti @jenkins-tessares
tools: ynl-gen: add support for exact-len validation
59a89f9 
add support for 'exact-len' validation on netlink attributes.

Link: #340
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Acked-by: Matthieu Baerts <matttbe@kernel.org>
jenkins-tessares pushed a commit that referenced this issue Oct 24, 2023
@dcaratti @jenkins-tessares
net: mptcp: convert netlink from small_ops to ops
4128c28 
in the current MPTCP control plane, all operations use a netlink
attribute of the same type "MPTCP_PM_ATTR". However, add/del/get/flush
operations only parse the first element in the message _ the one that
describes MPTCP endpoints (that was named MPTCP_PM_ATTR_ADDR and
mostly used in ADD_ADDR operations _ probably the similarity of "attr",
"addr" and "add" might cause some confusion to human readers).
Convert MPTCP from 'small_ops' to 'ops', thus allowing different attributes
for each single operation, hopefully makes all this clearer to human
readers.

- use a separate attribute set for add/del/get/flush address operation,
  binary compatible with the existing one, to store the endpoint address.
  MPTCP_PM_ENDPOINT_ADDR is added to the uAPI (with the same value as
  MPTCP_PM_ATTR_ADDR) for these operations.
- convert mptcp_pm_ops[] and add policy files accordingly.

this prepares MPTCP control plane to be described as YAML spec.

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Oct 24, 2023
@dcaratti @jenkins-tessares
Documentation: netlink: add a YAML spec for mptcp
628a164 
it describes most of the current netlink interface (uAPI definitions,
doit/dumpit operations and attributes)

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Oct 24, 2023
@dcaratti @jenkins-tessares
uapi: mptcp: use header file generated from YAML spec
f3825bc 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode uapi \
 > --spec Documentation/netlink/specs/mptcp.yaml \
 > --header -o include/uapi/linux/mptcp_pm.h

Link: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Oct 24, 2023
@dcaratti @jenkins-tessares
net: mptcp: rename netlink handlers to mptcp_pm_nl_<blah>_{doit,dumpit}
021230f 
so that they will match names generated from YAML spec.

Link: #340
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Oct 24, 2023
@dcaratti @jenkins-tessares
net: mptcp: use policy generated by YAML spec
0e78ecd 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --source \
 > -o net/mptcp/mptcp_pm_gen.c
 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --header \
 > -o net/mptcp/mptcp_pm_gen.h

Closes: #340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Oct 24, 2023
@dcaratti @kuba-moo
tools: ynl-gen: add support for exact-len validation
0c63ad3 
add support for 'exact-len' validation on netlink attributes.

Link: multipath-tcp/mptcp_net-next#340
Acked-by: Matthieu Baerts <matttbe@kernel.org>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <martineau@kernel.org>
Link: https://lore.kernel.org/r/20231023-send-net-next-20231023-1-v2-2-16b1f701f900@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Oct 24, 2023
@dcaratti @kuba-moo
net: mptcp: convert netlink from small_ops to ops
1d0507f 
in the current MPTCP control plane, all operations use a netlink
attribute of the same type "MPTCP_PM_ATTR". However, add/del/get/flush
operations only parse the first element in the message _ the one that
describes MPTCP endpoints (that was named MPTCP_PM_ATTR_ADDR and
mostly used in ADD_ADDR operations _ probably the similarity of "attr",
"addr" and "add" might cause some confusion to human readers).
Convert MPTCP from 'small_ops' to 'ops', thus allowing different attributes
for each single operation, hopefully makes all this clearer to human
readers.

- use a separate attribute set for add/del/get/flush address operation,
  binary compatible with the existing one, to store the endpoint address.
  MPTCP_PM_ENDPOINT_ADDR is added to the uAPI (with the same value as
  MPTCP_PM_ATTR_ADDR) for these operations.
- convert mptcp_pm_ops[] and add policy files accordingly.

this prepares MPTCP control plane to be described as YAML spec.

Link: multipath-tcp/mptcp_net-next#340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <martineau@kernel.org>
Link: https://lore.kernel.org/r/20231023-send-net-next-20231023-1-v2-3-16b1f701f900@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Oct 24, 2023
@dcaratti @kuba-moo
Documentation: netlink: add a YAML spec for mptcp
bc8aeb2 
it describes most of the current netlink interface (uAPI definitions,
doit/dumpit operations and attributes)

Link: multipath-tcp/mptcp_net-next#340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <martineau@kernel.org>
Link: https://lore.kernel.org/r/20231023-send-net-next-20231023-1-v2-4-16b1f701f900@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Oct 24, 2023
@dcaratti @kuba-moo
uapi: mptcp: use header file generated from YAML spec
9d1ed17 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode uapi \
 > --spec Documentation/netlink/specs/mptcp.yaml \
 > --header -o include/uapi/linux/mptcp_pm.h

Link: multipath-tcp/mptcp_net-next#340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <martineau@kernel.org>
Link: https://lore.kernel.org/r/20231023-send-net-next-20231023-1-v2-5-16b1f701f900@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Oct 24, 2023
@dcaratti @kuba-moo
net: mptcp: rename netlink handlers to mptcp_pm_nl_<blah>_{doit,dumpit}
1e07938 
so that they will match names generated from YAML spec.

Link: multipath-tcp/mptcp_net-next#340
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <martineau@kernel.org>
Link: https://lore.kernel.org/r/20231023-send-net-next-20231023-1-v2-6-16b1f701f900@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Oct 24, 2023
@dcaratti @kuba-moo
net: mptcp: use policy generated by YAML spec
aab4d85 
generated with:

 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --source \
 > -o net/mptcp/mptcp_pm_gen.c
 $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \
 > --spec Documentation/netlink/specs/mptcp.yaml --header \
 > -o net/mptcp/mptcp_pm_gen.h

Closes: multipath-tcp/mptcp_net-next#340
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <martineau@kernel.org>
Link: https://lore.kernel.org/r/20231023-send-net-next-20231023-1-v2-7-16b1f701f900@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
bella485 pushed a commit to bella485/centos-stream-9 that referenced this issue May 1, 2024
@orosp
tools: ynl-gen: add support for exact-len validation
57adc23 
JIRA: https://issues.redhat.com/browse/RHEL-30145

Upstream commit(s):
commit 0c63ad3795269849782ca24a084952206986d3bf
Author: Davide Caratti <dcaratti@redhat.com>
Date:   Mon Oct 23 11:17:06 2023 -0700

    tools: ynl-gen: add support for exact-len validation

    add support for 'exact-len' validation on netlink attributes.

    Link: multipath-tcp/mptcp_net-next#340
    Acked-by: Matthieu Baerts <matttbe@kernel.org>
    Signed-off-by: Davide Caratti <dcaratti@redhat.com>
    Signed-off-by: Mat Martineau <martineau@kernel.org>
    Link: https://lore.kernel.org/r/20231023-send-net-next-20231023-1-v2-2-16b1f701f900@kernel.org
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Signed-off-by: Petr Oros <poros@redhat.com>
bella485 pushed a commit to bella485/centos-stream-9 that referenced this issue May 1, 2024
@orosp
tools: ynl-gen: add support for exact-len validation
b1f0c4c 
JIRA: https://issues.redhat.com/browse/RHEL-30145

Upstream commit(s):
commit 0c63ad3795269849782ca24a084952206986d3bf
Author: Davide Caratti <dcaratti@redhat.com>
Date:   Mon Oct 23 11:17:06 2023 -0700

    tools: ynl-gen: add support for exact-len validation

    add support for 'exact-len' validation on netlink attributes.

    Link: multipath-tcp/mptcp_net-next#340
    Acked-by: Matthieu Baerts <matttbe@kernel.org>
    Signed-off-by: Davide Caratti <dcaratti@redhat.com>
    Signed-off-by: Mat Martineau <martineau@kernel.org>
    Link: https://lore.kernel.org/r/20231023-send-net-next-20231023-1-v2-2-16b1f701f900@kernel.org
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Signed-off-by: Petr Oros <poros@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcaratti dcaratti

Labels
enhancement
Projects
No open projects
MPTCP Next (6.4)
To do
MPTCP Upstream: Next (6.7)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matttbe @dcaratti