Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32-bit DATA_FIN not expanded to 64 bits #93

Closed
mjmartineau opened this issue Sep 25, 2020 · 1 comment
Closed

32-bit DATA_FIN not expanded to 64 bits #93

mjmartineau opened this issue Sep 25, 2020 · 1 comment
Assignees
@mjmartineau
Labels
bug

Comments

@mjmartineau
Copy link
Member

Incoming DATA_FIN sequence numbers were always treated as 64 bits when comparing them to msk->ack_seq, so the upper 32 bits would not match when the peer sent 32-bit DATA_FIN sequence numbers and no acknowledgement of the DATA_FIN would be sent.

Found while interop testing with mptcp_trunk.
@mjmartineau mjmartineau added this to the v5.9 milestone Sep 25, 2020
@mjmartineau mjmartineau self-assigned this Sep 25, 2020
@mjmartineau
Copy link
Member Author

Proposed fix: http://patchwork.ozlabs.org/project/mptcp/list/?series=204282

fengguang pushed a commit to 0day-ci/linux that referenced this issue Sep 29, 2020
@mjmartineau @intel-lab-lkp
mptcp: Handle incoming 32-bit DATA_FIN values
91d93be 
The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
sequence number. When a 32-bit sequence number is received for the
DATA_FIN, it must be expanded to 64 bits before comparing it to the
last acked sequence number. This expansion was missing.

Closes: multipath-tcp/mptcp_net-next#93
Fixes: 3721b9b (mptcp: Track received DATA_FIN sequence number and add related helpers)
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Sep 30, 2020
@mjmartineau @davem330
mptcp: Handle incoming 32-bit DATA_FIN values
1a49b2c 
The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
sequence number. When a 32-bit sequence number is received for the
DATA_FIN, it must be expanded to 64 bits before comparing it to the
last acked sequence number. This expansion was missing.

Closes: multipath-tcp/mptcp_net-next#93
Fixes: 3721b9b ("mptcp: Track received DATA_FIN sequence number and add related helpers")
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
matttbe pushed a commit that referenced this issue Sep 30, 2020
@mjmartineau @matttbe
mptcp: Handle incoming 32-bit DATA_FIN values
69bd9c6 
The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
sequence number. When a 32-bit sequence number is received for the
DATA_FIN, it must be expanded to 64 bits before comparing it to the
last acked sequence number. This expansion was missing.

Closes: #93
Fixes: 3721b9b (mptcp: Track received DATA_FIN sequence number and add related helpers)
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
jenkins-tessares pushed a commit that referenced this issue Oct 1, 2020
@mjmartineau @jenkins-tessares
mptcp: Handle incoming 32-bit DATA_FIN values
c083e0d 
The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
sequence number. When a 32-bit sequence number is received for the
DATA_FIN, it must be expanded to 64 bits before comparing it to the
last acked sequence number. This expansion was missing.

Closes: #93
Fixes: 3721b9b (mptcp: Track received DATA_FIN sequence number and add related helpers)
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
jenkins-tessares pushed a commit that referenced this issue Oct 2, 2020
@mjmartineau @jenkins-tessares
mptcp: Handle incoming 32-bit DATA_FIN values
a639dbe 
The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
sequence number. When a 32-bit sequence number is received for the
DATA_FIN, it must be expanded to 64 bits before comparing it to the
last acked sequence number. This expansion was missing.

Closes: #93
Fixes: 3721b9b (mptcp: Track received DATA_FIN sequence number and add related helpers)
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
jenkins-tessares pushed a commit that referenced this issue Oct 2, 2020
@mjmartineau @jenkins-tessares
mptcp: Handle incoming 32-bit DATA_FIN values
dc5e891 
The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
sequence number. When a 32-bit sequence number is received for the
DATA_FIN, it must be expanded to 64 bits before comparing it to the
last acked sequence number. This expansion was missing.

Closes: #93
Fixes: 3721b9b (mptcp: Track received DATA_FIN sequence number and add related helpers)
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
jenkins-tessares pushed a commit that referenced this issue Oct 2, 2020
@mjmartineau @jenkins-tessares
mptcp: Handle incoming 32-bit DATA_FIN values
67908dc 
The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
sequence number. When a 32-bit sequence number is received for the
DATA_FIN, it must be expanded to 64 bits before comparing it to the
last acked sequence number. This expansion was missing.

Closes: #93
Fixes: 3721b9b (mptcp: Track received DATA_FIN sequence number and add related helpers)
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
jenkins-tessares pushed a commit that referenced this issue Oct 3, 2020
@mjmartineau @jenkins-tessares
mptcp: Handle incoming 32-bit DATA_FIN values
d0a5f00 
The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
sequence number. When a 32-bit sequence number is received for the
DATA_FIN, it must be expanded to 64 bits before comparing it to the
last acked sequence number. This expansion was missing.

Closes: #93
Fixes: 3721b9b (mptcp: Track received DATA_FIN sequence number and add related helpers)
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
jenkins-tessares pushed a commit that referenced this issue Oct 3, 2020
@mjmartineau @jenkins-tessares
mptcp: Handle incoming 32-bit DATA_FIN values
4b09ad4 
The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
sequence number. When a 32-bit sequence number is received for the
DATA_FIN, it must be expanded to 64 bits before comparing it to the
last acked sequence number. This expansion was missing.

Closes: #93
Fixes: 3721b9b (mptcp: Track received DATA_FIN sequence number and add related helpers)
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
jenkins-tessares pushed a commit that referenced this issue Oct 3, 2020
@mjmartineau @jenkins-tessares
mptcp: Handle incoming 32-bit DATA_FIN values
aed285c 
The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
sequence number. When a 32-bit sequence number is received for the
DATA_FIN, it must be expanded to 64 bits before comparing it to the
last acked sequence number. This expansion was missing.

Closes: #93
Fixes: 3721b9b (mptcp: Track received DATA_FIN sequence number and add related helpers)
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
jenkins-tessares pushed a commit that referenced this issue Oct 4, 2020
@mjmartineau @jenkins-tessares
mptcp: Handle incoming 32-bit DATA_FIN values
9169d71 
The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
sequence number. When a 32-bit sequence number is received for the
DATA_FIN, it must be expanded to 64 bits before comparing it to the
last acked sequence number. This expansion was missing.

Closes: #93
Fixes: 3721b9b (mptcp: Track received DATA_FIN sequence number and add related helpers)
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
jenkins-tessares pushed a commit that referenced this issue Oct 5, 2020
@mjmartineau @jenkins-tessares
mptcp: Handle incoming 32-bit DATA_FIN values
15e4498 
The peer may send a DATA_FIN mapping with either a 32-bit or 64-bit
sequence number. When a 32-bit sequence number is received for the
DATA_FIN, it must be expanded to 64 bits before comparing it to the
last acked sequence number. This expansion was missing.

Closes: #93
Fixes: 3721b9b (mptcp: Track received DATA_FIN sequence number and add related helpers)
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
jenkins-tessares pushed a commit that referenced this issue Feb 22, 2021
@amluto
x86/fault: Improve kernel-executing-user-memory handling
03c81ea 
Right now, the case of the kernel trying to execute from user memory
is treated more or less just like the kernel getting a page fault on a
user access. In the failure path, it checks for erratum #93, tries to
otherwise fix up the error, and then oopses.

If it manages to jump to the user address space, with or without SMEP,
it should not try to resolve the page fault. This is an error, pure and
simple. Rearrange the code so that this case is caught early, check for
erratum #93, and bail out.

 [ bp: Massage commit message. ]

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/ab8719c7afb8bd501c4eee0e36493150fbbe5f6a.1612924255.git.luto@kernel.org
matttbe pushed a commit that referenced this issue Apr 10, 2024
selftests/bpf: add test for bpf_for_each_map_elem() with different maps
fecb159 
A test is added for bpf_for_each_map_elem() with either an arraymap or a
hashmap.
$ tools/testing/selftests/bpf/test_progs -t for_each
 #93/1    for_each/hash_map:OK
 #93/2    for_each/array_map:OK
 #93/3    for_each/write_map_key:OK
 #93/4    for_each/multi_maps:OK
 #93      for_each:OK
Summary: 1/4 PASSED, 0 SKIPPED, 0 FAILED

Signed-off-by: Philo Lu <lulie@linux.alibaba.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/20240405025536.18113-4-lulie@linux.alibaba.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjmartineau mjmartineau

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mjmartineau