Add wait statistics to pools #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmrichards
suggested changes
Mar 1, 2019
redis/pool.go
Outdated
| active int // the number of open connections in the pool | ||
| ch chan struct{} // limits open connections when p.Wait is true | ||
| idle idleList // idle connections | ||
| waitCount int64 // Total number of connections waited for. |
There was a problem hiding this comment.
For consistency sake: Total -> total
redis/pool.go
Outdated
| ch chan struct{} // limits open connections when p.Wait is true | ||
| idle idleList // idle connections | ||
| waitCount int64 // Total number of connections waited for. | ||
| waitDuration time.Duration // Total time waited for new connections. |
There was a problem hiding this comment.
For consistency sake: Total -> total
redis/pool_test.go
Outdated
| d.check_all(message, p, dialed, open, inuse, 0, 0) | ||
| } | ||
|
|
||
| func (d *poolDialer) check_all(message string, p *redis.Pool, dialed, open, inuse int, waitCountMax int64, waitDurationMax time.Duration) { |
|
|
||
| // wait indicates if we believe it will block so its not 100% accurate | ||
| // however for stats it should be good enough. | ||
| wait := len(p.ch) == 0 |
There was a problem hiding this comment.
Inherently racey but if you want to just get wait stats when you think the channel will block, not sure there is any other way.
Is there any reason you can't do the wait stat calculation all the time? It'll be ~0 in non-blocking cases so maybe not much use?
There was a problem hiding this comment.
It would just break the count as every request would flagged as waited.
Add WaitCount and WaitDuration stats to pool stats to enable tracking of the delays introduced by waiting for connections from the pool. This uses the same properties as database/sql so its familiar to users. Addresses: gomodule#403
danmrichards
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WaitCount and WaitDuration stats to pool stats to enable tracking of the delays introduced by waiting for connections from the pool.
This uses the same properties as database/sql so its familiar to users.
Addresses: gomodule#403