Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger error messages should be improved #340

Open
CrosRoad95 opened this issue Aug 25, 2018 · 4 comments
Open

Trigger error messages should be improved #340

CrosRoad95 opened this issue Aug 25, 2018 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@CrosRoad95
Copy link
Contributor

Is your feature request related to a problem? Please describe.
error that appear while event isn't added should contain source from where was triggered. Now i see only that random event was triggered, nothing else. If server have a lot of events, search can take forever.

Describe the solution you'd like
Add information about source of error ( resource, file, line ).

Describe alternatives you've considered
add event onEvent which first argument is event name and rest of arguments are from trigger.

Additional context

m_pScriptDebugging->LogError(NULL, "Client (%s) triggered serverside event %s, but event is not added serverside", pCaller->GetNick(), szName);

@patrikjuvonen patrikjuvonen added the enhancement New feature or request label Aug 25, 2018
@Einheit-101
Copy link

This debug message is completely unnecessary for the client anyway. It gets also triggered when the server tries to trigger a client side event when the client has not even started its resources, it is not even harmful. I would like to get rid of it entirely without creating hackfixes in Lua for it.

@botder botder self-assigned this Jan 4, 2019
@botder
Copy link
Member

botder commented Jan 6, 2019

I would like to keep the debug message. It might not be harmful, but clearly shows the issue with a script/resource and non-familiar scripters don't have to research why their resource doesn't work correctly.

I could push the referenced commit if this issue is a real problem. The images below show the added "in resource <name>":
image
image

@qaisjp
Copy link
Contributor

qaisjp commented Jan 6, 2019

The debug messages are useful indeed.

Crosroad suggested that setDevelopmentMode could be used to enable more specific error messages that might be a bit heavy for events. Do you think this is worth investigating?

@botder
Copy link
Member

botder commented Jan 6, 2019

Yes, I could try that.

botder added a commit to botder/mtasa-blue that referenced this issue Jan 9, 2019
@botder botder added this to the Backlog milestone Mar 3, 2019
@botder botder removed their assignment May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants