Chatbox spam by weird characters

[ArranTuna]

Describe the bug
Recently some players found out how to spam -every- MTA chatbox with a weird symbol.

See the screenshot for an example.

To reproduce
Unknown as the mantis report did not contain the stated characters but the lua code below might help.

Expected behaviour

Screenshots

Version

Additional context
StuartUK:
This should remove allot of it they are most of the characters I found

function removeChatSpam(msg)
	local newMsg = ""
	for i = 1, utfLen(msg) do
		local char = utfCode(utfSub(msg,i,i))
		if(not (char >= 768 and char <= 879)) then
			newMsg = newMsg .. utfSub(msg,i,i)
		end
	end
	return newMsg
end

From https://bugs.mtasa.com/view.php?id=8114

[LosFaul]

This exists in endless other programs too and has something to do with special control characters.
So, it's more or less an issue of UTF-8/Unicode

[qaisjp]

I think it might be a good idea to include a fix for this in freeroam.

[Dutchman101]

I think it might be a good idea to include a fix for this in freeroam.

I doubt that freeroam is the only gamemode in official resources with its own chathandler..
Is there a particular reason for only suggesting freeroam?

Also, if you think fixing it in resources is the proper approach, then maybe we should add it regardless of official gamemode, which means we'd be adding chathandlers to any gamemode that does not have it.

[qaisjp]

Reproducible using: run outputChatBox("ą̷̳͎͚̫̱̼͚́̏͗́͋͆̆̋͋̑͛̅͗̀͌͐͒̓͋̋̅̑͒̔̉̓͒̀̃̊̒͌͆̆͐̒̂͒̄̉̂̆̾̋͋̊̂̈́̈́̈͘̚̕͘̚͘͝͝͝͝͝"). This is called "zalgo text".

My initial reasoning for fixing this in resources is that I don't think we shouldn't attempt to "fix" text with excessive diacritics as we cannot guarantee we are affecting legitimate use. A proper fix is to crop text rendering instead, as detailed below.

---

This can be fixed by ensuring CChatLineSection::Draw is passed an appropriate render boundary.

This issue can be hackily fixed by changing line 1120 of CChatLine::Draw from:

(*iter).Draw(..., RenderBounds);

to:

(*iter).Draw(..., CRect2D(vecPosition.fX, vecPosition.fY, RenderBounds.fY1, vecPosition.fY+13));

This is obviously not a suitable fix as 13 above should be CChat::GetDrawList fLineDifference... and the RenderBounds should be correct in the first place.

The RenderBounds is originally created in CChat::GetDrawList and passed through CChat::DrawDrawList.

Two options:

• Add a render bounds field per SDrawListLineItem
• Do what CChatInputLine::Draw does and just get the font height when drawing (see Fix #557: zalgo chat messages spill over #885)