Fix #557: zalgo chat messages spill over #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the render bounds for a singular chat line would be the entire chat render bounds. Now the render bounds for a singular chat line are: - left: chat line x - top: chat line y - right: entire chat right - bottom: chat line y + chat line height Also fixes a minor off-by-one logical error in CChat::DrawTextString relating to render boundaries.
|
Nice work! |
sbx320
approved these changes
Apr 27, 2019
|
Looks good to me, although I'm unable to try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the render bounds for a singular chat line would be the entire chat render bounds. This has now been fixed to be the height of a single line.
Also fixes a minor off-by-one logical error in CChat::DrawTextString relating to render boundaries. I am not sure if this fix here is correct.
See #557 (comment).