Update colshape and marker hit detection when attaching

[Lpsd]

Fixes #1317

[qaisjp]

does this fix markers too?

[Lpsd]

I haven't tested with markers - it's getting pretty late so I'll investigate that tomorrow.

[Lpsd]

I've implemented this for markers too (it had the same issue as colshapes).

[qaisjp]

lgtm

[qaisjp]

have you tried overloading AttachTo? it's being called 2 lines above your additions

qaisjp@EdinburPro: ~/Documents/mtasa-blue git:(master) ✗
➜ ag "void AttachTo"
Server/mods/deathmatch/logic/CBlip.h
33:    void AttachTo(CElement* pElement);

Client/mods/deathmatch/logic/CClientPickup.h
109:    void AttachTo(CClientEntity* pEntity) override;

Client/mods/deathmatch/logic/CClientObject.h
51:    void AttachTo(CClientEntity* pEntity) override;




qaisjp@EdinburPro: ~/Documents/mtasa-blue git:(master) ✗
➜ ag "::AttachTo"
Server/mods/deathmatch/logic/CBlip.cpp
162:void CBlip::AttachTo(CElement* pElement)
164:    CElement::AttachTo(pElement);

Server/mods/deathmatch/logic/CElement.cpp
1080:void CElement::AttachTo(CElement* pElement)

Client/mods/deathmatch/logic/CClientPickup.cpp
95:void CClientPickup::AttachTo(CClientEntity* pEntity)
97:    CClientEntity::AttachTo(pEntity);

Client/mods/deathmatch/logic/CClientCamera.cpp
292:void CClientCamera::AttachTo(CElement* pElement)
301:    CClientEntity::AttachTo(pElement);

Client/mods/deathmatch/logic/CClientObject.cpp
177:void CClientObject::AttachTo(CClientEntity* pEntity)
179:    CClientEntity::AttachTo(pEntity);

Client/mods/deathmatch/logic/CClientEntity.cpp
605:void CClientEntity::AttachTo(CClientEntity* pEntity)

[Lpsd]

I've changed the implementation as suggested.

[ghost]

Nice work! @qaisjp looks good. Should we merge it?

[Lpsd]

@saml1er there's a problem with a crash upon exiting MTA which seems to have been introduced by these changes. I'm still investigating - see below:

Version = 1.5.7-custom.0.000
Time = Sat Mar 28 01:59:43 2020
Module = C:\Users\Ryan\Documents\GitHub\mtasa-blue\Bin\mods\deathmatch\client.dll
Code = 0xC0000005
Offset = 0x0004CCE5

EAX=00000000  EBX=1A3B6901  ECX=00000000  EDX=00000000  ESI=2680EB58
EDI=2669A3C0  EBP=0177F280  ESP=0177F280  EIP=7BCACCE5  FLG=00210246
CS=0023   DS=002B  SS=002B  ES=002B   FS=0053  GS=002B

[Lpsd]

I've fixed the crash mentioned above with the latest commit. Ready to go.

[qaisjp]