setWaterLevel: add bIncludeWorldSeaLevel and bIncludeOutsideWorldLevel #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pirulax
reviewed
Jul 2, 2020
Comment on lines
+752
to
+758
| for (DWORD i = 0; i < NUM_DefWaterVertices; i++) | ||
| { | ||
| m_Vertices[i].GetPosition(vecVertexPos); | ||
| if ((bIncludeWorldNonSeaLevel && m_Vertices[i].IsWorldNonSeaLevel()) || (bIncludeWorldSeaLevel && !m_Vertices[i].IsWorldNonSeaLevel())) | ||
| vecVertexPos.fZ = fLevel; | ||
| m_Vertices[i].SetPosition(vecVertexPos, pChangeSource); | ||
| } |
There was a problem hiding this comment.
Not sure what's the type of m_Vertices, but Im pretty sure you could use a for based range loop (eg.: for(auto& vertex : m_Vertices)
There was a problem hiding this comment.
NUM_DefWaterVertices is constant value, I think that i will leave this.
|
Seems okay to me. |
StrixG
reviewed
Oct 25, 2020
StrixG
changed the title
StrixG
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to change the water level outside the game world.
New syntax:
Reopened #1342 #889